Add flag to use Chrome "Black Frame Decoder", skipping video decode complexity. #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omplexity. Enabled for Malleus, disabled for other tests.
bgrozev
reviewed
Jul 19, 2022
scripts/malleus.sh
Outdated
| @@ -86,6 +86,10 @@ set_defaults() { | |||
| MALLEUS_USE_STAGE_VIEW=false | |||
| fi | |||
|
|
|||
| if [ -z "$MALLEUS_ENABLE_DECODING"; then | |||
|
Note this flag hasn't actually landed in Chrome yet, so don't merge this until it does. See https://webrtc-review.googlesource.com/c/src/+/267820/14 |
fippo
reviewed
Jul 20, 2022
| @@ -254,6 +254,11 @@ else if (participantType == ParticipantType.edge) | |||
| ops.addArguments("window-size=1200x600"); | |||
| } | |||
|
|
|||
| if (options.getDisableDecoding()) | |||
| { | |||
| ops.addArguments("force-fieldtrials=WebRTC-BlackFrameDecoder/Enabled/"); | |||
There was a problem hiding this comment.
beware, the current plan is to enable this as a separate flag for consistency with other decoders:
--use-black-frame-decoder-for-peer-connection
-- will update the webrtc CL description accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled for Malleus, disabled for other tests.