Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(silent): hide unmute if participant joined without audio #14803

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nbeckindy
Copy link
Contributor

A fix for this issue I submitted earlier: #14559

Not sure if this is the way you'd want to go about resolving this problem, but this is how we handled it.

Depends on this PR in the lib-jitsi-meet repo: jitsi/lib-jitsi-meet#2534

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.


room.on(
JitsiConferenceEvents.SILENT_STATUS_CHANGED,
(id, isSilent) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need it and here, isn't the one in base/conference/actions.any.ts enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the same thing, but if I remove the listener from conference.js, other browser-based participants don't see the silent status. And if I remove the listener in base/conference/actions.any.ts, mobile app participants don't see the status. I could only get it to work on both platforms with both of these listeners. I never could figure out why that's the case though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants