Lower hand #14851
Lower hand #14851
Conversation
|
Hi, thanks for your contribution! |
liumengyuan1997
force-pushed
the
lower-hand
branch
from
03484de
to
efebe1e
Compare
| // raisedHandTimestamp: participant.raisedHandTimestamp | ||
| // }); | ||
|
|
||
| queue = [ ...queue, { id: participant.id, |
lang/main.json
Outdated
| @@ -786,6 +786,7 @@ | |||
| "newDeviceAction": "Use", | |||
| "newDeviceAudioTitle": "New audio device detected", | |||
| "newDeviceCameraTitle": "New camera detected", | |||
| "nextToSpeak": "Your turn to speak might come soon, get ready", | |||
There was a problem hiding this comment.
Let's do the next to speak as a separate PR, since it's not related to lowering the hand.
| @@ -1,8 +1,10 @@ | |||
|
|
|||
| @@ -147,6 +151,9 @@ export const FooterContextMenu = ({ isOpen, onDrawerClose, onMouseLeave }: IProp | |||
| onClick: muteAllVideo, | |||
| text: t('participantsPane.actions.stopEveryonesVideo') | |||
| } ] } /> | |||
| {raisedHandsQueue.length !== 0 && (<LowerHandButton | |||
There was a problem hiding this comment.
Is this check correct also when it's just the local user the one who raised the hand?
| * | ||
| * @returns {Function} A function that dispatches a notification action. | ||
| */ | ||
| export function notifyToSpeak() { |
There was a problem hiding this comment.
Note for the next PR: don't put this in actions.web since we'll want to reuse it for mobile too.
|
|
||
| const handleClick = useCallback(() => { | ||
| try { | ||
| _isModerator && conference?.sendEndpointMessage( |
There was a problem hiding this comment.
This button should not be visible for non-moderators. Are we testing that?
| @@ -19,6 +20,8 @@ MiddlewareRegistry.register(store => next => action => { | |||
| /* onAllow */ () => APP.store.dispatch(setCameraFacingMode(data.facingMode)), | |||
| /* initiatorId */ participant.getId() | |||
| )); | |||
| } else if (data?.name === LOWER_HAND) { | |||
There was a problem hiding this comment.
Check that the sender is a moderator.
liumengyuan1997
force-pushed
the
lower-hand
branch
from
bad19c7
to
5adaadf
Compare
Dear reviewer,
I have implemented functionality to lower a participant's hand and lower all hands for the meeting moderator. There are also some remaining code sections related to creating notifications for the next speaker. I have commented out notification-related listeners as these features are not yet fully implemented. I look forward to receiving your comments and advice on these updates.
All the best,
Mengyuan