feat(external_api) add ability to start transcriptions together with … #14858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -715,25 +717,33 @@ function initCommands() { | |||
| mode: JitsiRecordingConstants.mode.STREAM, | |||
| streamId: youtubeStreamKey || rtmpStreamKey | |||
| }; | |||
| } else { | |||
| logger.error('Invalid recording mode provided'); | |||
There was a problem hiding this comment.
We don't need the print anymore?
There was a problem hiding this comment.
No because if there is no recording the mode won't be set, just the transcription flag.
| @@ -743,6 +753,13 @@ function initCommands() { | |||
| return; | |||
| } | |||
|
|
|||
| if (transcription) { | |||
There was a problem hiding this comment.
I'm wondering if the the recording have been started with transcription but it is stopped with transcription false, what would happen? The transcription will just continue?
Also what happens if the recording have been started without transcription but it is stopped with transcription true. Have you tested it?
There was a problem hiding this comment.
Yes, the transcription is allowed to continue in that case.
hristoterezov
approved these changes
Jun 24, 2024
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…recordings