Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve participants button aria-label for screen reader users #14997

Conversation

ahmadkadri
Copy link
Contributor

@ahmadkadri ahmadkadri commented Aug 12, 2024

Description: In the participant button in the toolbar the number of participants is displayed but it is not accessed for the screen reader users.

Actual Behavior: The screen reader read just the word open participants pane.

Expected Behavior: The number of participants should also be provided for screen reader users.

Before:

withoutParticipantsCount.mp4

After:

ParticipantsCount.mp4

issue jitsi community: https://community.jitsi.org/t/accessibility-improvement/133102

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@Calinteodor
Copy link
Contributor

@ahmadkadri Thank you for your contribution! Can you please fix the linter issues?

@Calinteodor
Copy link
Contributor

Jenkins please test this please!

@Calinteodor
Copy link
Contributor

Calinteodor commented Aug 13, 2024

@ahmadkadri There are some failing tests related to your changes.

You must fork and create here https://github.com/jitsi/jitsi-meet-torture a branch with the same name as this one, check the tests that are failing by running this command

mvn clean test
-DforkCount=0
-Djitsi-meet.instance.url="https://localhost:8080/"
-Dtest.report.directory=target/chrome-2-chrome
-Djitsi-meet.tests.toRun=TEST_NAME

@damencho
Copy link
Member

damencho commented Sep 9, 2024

Jenkins test this please.

@ahmadkadri
Copy link
Contributor Author

@damencho we had tow kind of failed tests on open and on close. i improve the code so we still have to fix on open in the test (we work on it).

@emrahcom
Copy link
Contributor

I created jitsi/jitsi-meet-torture#653
Could you run the test again please

@Calinteodor
Copy link
Contributor

I created jitsi/jitsi-meet-torture#653 Could you run the test again please

Let's wait until the PR is merged.

@damencho
Copy link
Member

Jenkins test this please.

@damencho
Copy link
Member

damencho commented Oct 7, 2024

Sorry for the late reply, now I checked, and the same label 'toolbar.accessibilityLabel.participants' is used in and in the native code, which needs adjusting the same way as the web.

@Calinteodor
Copy link
Contributor

PR continue here #15204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants