-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve participants button aria-label for screen reader users #14997
Improve participants button aria-label for screen reader users #14997
Conversation
[pull] master from jitsi:master
Hi, thanks for your contribution! |
@ahmadkadri Thank you for your contribution! Can you please fix the linter issues? |
Jenkins please test this please! |
@ahmadkadri There are some failing tests related to your changes. You must fork and create here https://github.com/jitsi/jitsi-meet-torture a branch with the same name as this one, check the tests that are failing by running this command mvn clean test |
Jenkins test this please. |
@damencho we had tow kind of failed tests on open and on close. i improve the code so we still have to fix on open in the test (we work on it). |
I created jitsi/jitsi-meet-torture#653 |
Let's wait until the PR is merged. |
Jenkins test this please. |
Sorry for the late reply, now I checked, and the same label |
react/features/participants-pane/components/web/ParticipantsPaneButton.tsx
Show resolved
Hide resolved
react/features/participants-pane/components/web/ParticipantsPaneButton.tsx
Show resolved
Hide resolved
react/features/participants-pane/components/web/ParticipantsPaneButton.tsx
Show resolved
Hide resolved
PR continue here #15204 |
Description: In the participant button in the toolbar the number of participants is displayed but it is not accessed for the screen reader users.
Actual Behavior: The screen reader read just the word open participants pane.
Expected Behavior: The number of participants should also be provided for screen reader users.
Before:
withoutParticipantsCount.mp4
After:
ParticipantsCount.mp4
issue jitsi community: https://community.jitsi.org/t/accessibility-improvement/133102