Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help button in the settings menu is hidden help.enabled is set to false. #15599

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

laky241
Copy link

@laky241 laky241 commented Feb 12, 2025

Fixes #15455

This PR ensures that the Help button in the settings menu is hidden when the feature flag help.enabled is set to false.

  • Added Help tab in SettingsDialog.js inside a feature flag check

  • Added HELP to SETTINGS_TABS in constants.js to prevent TypeScript errors.

Testing:

  • Make.setFeatureFlag("help.enabled", false).

  • check the Help button is removed from the settings screen.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@saghul
Copy link
Member

saghul commented Feb 13, 2025

Feature flags are a mobile thing and you are only using it in the web settings dialog. How exactly did you test this?

@laky241
Copy link
Author

laky241 commented Feb 13, 2025

@saghul I sincerely apologize for the initial approach we took to fix this issue. I now understand that we mistakenly applied a mobile feature flag in the web settings dialog,

I removed the Help tab directly from the web settings dialog

we now use on the web’s global configuration (interface_config.js).

Ran npm start and tested the web UI
Navigated to Settings, verified that the Help button is no longer visible.

@laky241
Copy link
Author

laky241 commented Feb 13, 2025

@jitsi-jenkins Thank you for the information, i have signed the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Help button is not hidden even when the feature flag is set to false.
3 participants