Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lobby: Redirect rejected user back to server start screen #7890

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gkdre234
Copy link

Currently the lobby screen is closed and only a small error box is shown to the rejected user.
Everything else looks like the user has joined the session successfully.

Issue #7337

With dispatch(cancelKnocking() rejected user will be forwarded back to the start screen.

Currently the lobby screen is closed and only a small error box is shown to the rejected user.
Everything else looks like the user has joined the session successfully.

With dispatch(cancelKnocking() rejected user will be forwarded back to the start screen.
…user-to-start

Lobby: Redirect rejected user back to server start screen.
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@damencho
Copy link
Member

Does the user get notified that he was rejected from lobby?

@saghul
Copy link
Member

saghul commented Oct 13, 2020

Other than being notified about that, does the code fire the CONFERENCE_TERMINATED event on mobile?

@gkdre234
Copy link
Author

gkdre234 commented Oct 13, 2020

Does the user get notified that he was rejected from lobby?

Yes.
Red messagebox for a few seconds.

@gkdre234
Copy link
Author

Other than being notified about that, does the code fire the CONFERENCE_TERMINATED event on mobile?

probably not

mobile

A message comes up. Conference is not closed.

@stale
Copy link

stale bot commented Jan 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Jan 19, 2021
@saghul saghul added the confirmed Confirmed bug, should not go stale label Mar 22, 2021
@stale stale bot removed the wontfix Issue won't be fixed label Mar 22, 2021
@@ -118,6 +119,7 @@ function _conferenceFailed({ dispatch, getState }, next, action) {
hideErrorSupportLink: true,
titleKey: 'lobby.joinRejectedMessage'
}));
dispatch(cancelKnocking());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gkdre234 for submitting this request. I find this proposal very useful.

Note that dispatching a notification will not wait for the timeout. In order to navigate to the main page after a timeout I have to use setTimeout(() => dispatch(cancelKnocking()), NOTIFICATION_TIMEOUT * 3);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Confirmed bug, should not go stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants