-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lobby: Redirect rejected user back to server start screen #7890
base: master
Are you sure you want to change the base?
Conversation
Currently the lobby screen is closed and only a small error box is shown to the rejected user. Everything else looks like the user has joined the session successfully. With dispatch(cancelKnocking() rejected user will be forwarded back to the start screen.
…user-to-start Lobby: Redirect rejected user back to server start screen.
Hi, thanks for your contribution! |
Does the user get notified that he was rejected from lobby? |
Other than being notified about that, does the code fire the CONFERENCE_TERMINATED event on mobile? |
Yes. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@@ -118,6 +119,7 @@ function _conferenceFailed({ dispatch, getState }, next, action) { | |||
hideErrorSupportLink: true, | |||
titleKey: 'lobby.joinRejectedMessage' | |||
})); | |||
dispatch(cancelKnocking()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gkdre234 for submitting this request. I find this proposal very useful.
Note that dispatching a notification will not wait for the timeout. In order to navigate to the main page after a timeout I have to use setTimeout(() => dispatch(cancelKnocking()), NOTIFICATION_TIMEOUT * 3);
Currently the lobby screen is closed and only a small error box is shown to the rejected user.
Everything else looks like the user has joined the session successfully.
Issue #7337
With dispatch(cancelKnocking() rejected user will be forwarded back to the start screen.