Expose forwarded endpoints changed and selection changed from Endpoint. #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstyura
changed the title
Fixed wrong method used to remove handler. Removed extra blank line.
mstyura
force-pushed
the
endpoint-events
branch
from
b9b20e4
to
6d5b7f9
Compare
bbaldino
reviewed
Apr 23, 2020
| @@ -1123,6 +1130,8 @@ public void sendLastNEndpointsChangeEvent( | |||
| forwardedEndpoints, endpointsEnteringLastN, conferenceEndpoints); | |||
|
|
|||
| sendMessage(msg); | |||
|
|
|||
| notifyForwardedEndpointsChanged(forwardedEndpoints, endpointsEnteringLastN, conferenceEndpoints); | |||
There was a problem hiding this comment.
Hm, wondering if this feels a bit weird since this call already came from outside the endpoint. If anything, it seems like we shouldn't forward this here and instead have BitrateController be the source of truth (like in your other PR)
There was a problem hiding this comment.
@bbaldino ah, very good point! Then I'll bring back event from bitrate controller and move message sending and forwarding event into event hander of bitrate controller.
There was a problem hiding this comment.
@bbaldino I think I've fixed an issues you've raising during previous review. Could you please give another chance for this PR and have a look at it? Thanks a lot!
Expose bitrate controller from endpoint. Use wildcard import. Adjusted implementation according to review feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates #1113.
I'm using
JVB 2.0as a library to add custom logic on top of an existing functionality. Custom logic is injected inJVBas a custom bundle. So in implementing additional functionality I'm limited to public API ofJVB.Currently I very much need to know when endpoint's set of forwarded endpoints has changed, and need to know when endpoint is selected/unselected by other endpoints. There is no public way to know when this happen, because event notification is sent silently (to my custom logic) over message transport.
It would be really nice to have these events exposed from
Endpoint, so I (and maybe others) is able to intercept an events and inject custom handler.Thanks you very much for review and considering this functionality!