Skip to content

Commit

Permalink
console: added hidden loadAsJson setting for CH
Browse files Browse the repository at this point in the history
  • Loading branch information
absorbb committed Jan 23, 2025
1 parent 09c5456 commit 4d48edc
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
1 change: 0 additions & 1 deletion webapps/console/components/DomainsEditor/DomainsEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ DomainConfigurationInstructions.show = p => {
export const DomainsEditor: React.FC<
{ context: "site" | "workspace"; workspaceDomains?: string[] } & CustomWidgetProps<string[]>
> = ({ onChange, value: domains, workspaceDomains, context }) => {
console.log("DomainsEditor", domains, workspaceDomains);
const [addValue, setAddValue] = useState<string | undefined>();
const [addPending, setAddPending] = useState(false);
const workspace = useWorkspace();
Expand Down
9 changes: 9 additions & 0 deletions webapps/console/lib/schema/destinations.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,12 @@ export const ClickhouseCredentials = z.object({
.describe(
"Additional parameters for ClickHouse driver. See <a href='https://clickhouse.com/docs/en/integrations/go#connection-settings-1' rel='noreferrer noopener' target='_blank'>Clickhouse documentation</a>"
),
loadAsJson: z
.boolean()
.default(false)
.describe(
"Load data in JSONEachRow. May offer better performance. May not work properly on old ClickHouse versions."
),
});

export type ClickhouseCredentials = z.infer<typeof ClickhouseCredentials>;
Expand Down Expand Up @@ -403,6 +409,9 @@ export const coreDestinations: DestinationType<any>[] = [
password: {
password: true,
},
loadAsJson: {
hidden: true,
},
},
},
{
Expand Down

0 comments on commit 4d48edc

Please sign in to comment.