mixpanel-destination: fix for null 'time' property and incorrect $ins…

…ert_id
jitsucom · Dec 25, 2023 · d7a602a · d7a602a · vercel · Dec 25, 2023
1 parent d18275b
commit d7a602a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/libs/core-functions/src/functions/lib/index.ts b/libs/core-functions/src/functions/lib/index.ts
@@ -102,8 +102,8 @@ export function createFilter(filter: string): (eventType: string, eventName?: st
 }
 
 export function eventTimeSafeMs(event: AnalyticsServerEvent) {
-  const ts = event.timestamp ? new Date(event.timestamp as string).getTime() : undefined;
-  const receivedAt = event.receivedAt ? new Date(event.receivedAt as string).getTime() : undefined;
   const now = new Date().getTime();
-  return Math.min(ts ?? now, receivedAt ?? now, now);
+  const ts = event.timestamp ? new Date(event.timestamp as string).getTime() : NaN;
+  const receivedAt = event.receivedAt ? new Date(event.receivedAt as string).getTime() : NaN;
+  return Math.min(!isNaN(ts) ? ts : now, !isNaN(receivedAt) ? receivedAt : now, now);
 }
diff --git a/libs/core-functions/src/functions/mixpanel-destination.ts b/libs/core-functions/src/functions/mixpanel-destination.ts
@@ -119,7 +119,7 @@ function trackEvent(
           time: eventTimeSafeMs(event),
           $device_id: deviceId,
           distinct_id: distinctId,
-          $insert_id: event.messageId + "-" + randomId(),
+          $insert_id: hash("md5", event.messageId) + "-" + randomId(),
           $user_id: event.userId ? `${event.userId}` : undefined,
           $browser: ctx.ua?.browser?.name,
           $browser_version: ctx.ua?.browser?.version,