rotor: Allow use of third-party S3-compatible storages for MaxMind #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmeremyanin
force-pushed
the
rotor-maxmind-s3-compatible-storage
branch
3 times, most recently
from
01910e9 to
4f9e90a
Compare
dmeremyanin
force-pushed
the
rotor-maxmind-s3-compatible-storage
branch
from
4f9e90a to
e237621
Compare
absorbb
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds support for specifying custom
endpointandforcePathStylesettings when creating the MaxMind S3 client. This enables the use of any third-party S3-compatible object storage service, such as DigitalOcean, MinIO, and others.New environment variables:
MAXMIND_S3_ENDPOINT(optional): Specifies the custom S3 endpoint.MAXMIND_S3_FORCE_PATH_STYLE(optional): Configures the URL style. By default, virtual-hosted-style URLs are used.Additionally, the
MAXMIND_prefix has been added to MaxMind-related S3 environment variables for consistency with other environment variables (MAXMIND_S3_BUCKET). The previous un-prefixed environment variables are still supported and will be used as fallbacks.