Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotor: Add support for custom CA certificate in Kafka SSL configuration #1175

Merged
merged 1 commit into from
Jan 27, 2025
Merged

rotor: Add support for custom CA certificate in Kafka SSL configuration #1175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 33 additions & 10 deletions services/rotor/src/lib/kafka-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import { Kafka, logLevel, CompressionCodecs, CompressionTypes } from "kafkajs";
import SnappyCodec from "kafkajs-snappy";
import "@sensejs/kafkajs-zstd-support";

import { LogMessageBuilder, requireDefined, randomId, getLog } from "juava";
import { readFileSync } from "fs";
import { isTruish, LogMessageBuilder, requireDefined, randomId, getLog } from "juava";
import JSON5 from "json5";
const log = getLog("kafka");

Expand All @@ -25,7 +26,7 @@ function translateLevel(l: logLevel): LogMessageBuilder {

export type KafkaCredentials = {
brokers: string[] | string;
ssl?: boolean;
ssl?: boolean | Record<string, any>;
sasl?: {
mechanism: "scram-sha-256" | "scram-sha-512";
username: string;
Expand All @@ -34,9 +35,37 @@ export type KafkaCredentials = {
};

export function getCredentialsFromEnv(): KafkaCredentials {
const ssl = isTruish(process.env.KAFKA_SSL);
const sslSkipVerify = isTruish(process.env.KAFKA_SSL_SKIP_VERIFY);

let sslOption: KafkaCredentials["ssl"] = undefined;

if (ssl) {
if (sslSkipVerify) {
// TLS enabled, but server TLS certificate is not verified
sslOption = {
rejectUnauthorized: false,
checkServerIdentity: () => undefined,
};
} else if (process.env.KAFKA_SSL_CA) {
// TLS enabled, server TLS certificate is verified using a custom CA certificate
sslOption = {
ca: process.env.KAFKA_SSL_CA,
};
} else if (process.env.KAFKA_SSL_CA_FILE) {
// TLS enabled, server TLS certificate is verified using a custom CA certificate (loaded from a local file)
sslOption = {
ca: readFileSync(process.env.KAFKA_SSL_CA_FILE, "utf-8"),
};
} else {
// TLS enabled, no extra configurations
sslOption = true;
}
}

return {
brokers: requireDefined(process.env.KAFKA_BOOTSTRAP_SERVERS, "env KAFKA_BOOTSTRAP_SERVERS is required").split(","),
ssl: process.env.KAFKA_SSL === "true" || process.env.KAFKA_SSL === "1",
ssl: sslOption,
sasl: process.env.KAFKA_SASL ? JSON5.parse(process.env.KAFKA_SASL) : undefined,
};
}
Expand All @@ -57,13 +86,7 @@ export function connectToKafka(opts: { defaultAppId: string } & KafkaCredentials
// },
clientId: process.env.APPLICATION_ID || opts.defaultAppId,
brokers: typeof opts.brokers === "string" ? opts.brokers.split(",") : opts.brokers,
ssl: opts.ssl
? {
rejectUnauthorized: false,
checkServerIdentity: () => undefined,
}
: undefined,

ssl: opts.ssl,
...sasl,
});
}
Expand Down
Loading