Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter regex #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add filter regex #27

wants to merge 2 commits into from

Conversation

rmed19
Copy link

@rmed19 rmed19 commented Apr 30, 2021

Filter changed files

@matthew-gerstman
Copy link

This is super useful for me. I'm currently pointing to the fork until this gets merged.

@Ana06
Copy link

Ana06 commented May 21, 2021

This is great! @sean-krail do you plan to merge this PR? 😄

@Ana06 Ana06 mentioned this pull request May 26, 2021
@Ana06
Copy link

Ana06 commented May 26, 2021

It seems this project is not maintained anymore or there is no interest on adding this. I really like this change @rmed19. So I have released Ana06/[email protected] which includes this change (with a small fix: Ana06@5e2c31d), #31 (pull_request_target support) and fixes the tests. 😄

@hiradp
Copy link
Contributor

hiradp commented May 28, 2021

Hey @Ana06 - thanks for forking and releasing. Yea the project was not being actively monitored. I am taking over and planning to merge and release.

Thanks for the contribution @rmed19.

@hiradp
Copy link
Contributor

hiradp commented May 28, 2021

@rmed19, the tests are failing because the filter is not provided. This makes me think that it's probably best to give this a default value of "*".

@Ana06
Copy link

Ana06 commented May 28, 2021

@hiradp

Hey @Ana06 - thanks for forking and releasing. Yea the project was not being actively monitored. I am taking over and planning to merge and release.

That's great! 🎉 Fell free to cherry-pick any of the changes I have made: Ana06/get-changed-files@v1...v1.1

@rmed19, the tests are failing because the filter is not provided. This makes me think that it's probably best to give this a default value of "*".

That is what I think too! I have fixed this in Ana06@5e2c31d

@vvasuki
Copy link

vvasuki commented Sep 23, 2023

https://github.com/marketplace/actions/changed-files seems to be a well maintained alternative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants