Mark span as error if not success response

jjatria · Dec 3, 2023 · d846630 · d846630
1 parent e04fd32
commit d846630
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/lib/Mojolicious/Plugin/OpenTelemetry.pm b/lib/Mojolicious/Plugin/OpenTelemetry.pm
@@ -79,11 +79,12 @@ sub register ( $, $app, $config, @ ) {
                 : Mojo::Promise->resolve(1);
 
             $promise->then( sub {
+                my $code  = $tx->res->code;
+                my $error = $code >= 400 && $code < 600;
+
                 $span
-                    ->set_status( SPAN_STATUS_OK )
-                    ->set_attribute(
-                        'http.response.status_code' => $tx->res->code,
-                    )
+                    ->set_status( $error ? SPAN_STATUS_ERROR : SPAN_STATUS_OK )
+                    ->set_attribute( 'http.response.status_code' => $code )
                     ->end;
             })->wait;