Closed
Conversation
Ran `flake8` on `devices/` and cleared out as many warnings as I could (ignoring line length warnings). The changes should be fine but I can't prove it as I don't have a testing Home Assistant setup yet (I run HAOS at home) and don't have line of sight on setting one up. LMK what you think!
The majority of the various feeder and fountain classes were copied from one another. This is an effort to make them easier to maintain by placing the code in one place while maintaining the same interface as before. As with PR jjjonesjr33#11 I still don't have a testing Home Assistant setup so I need to get that running first to verify that this actually works.
Test plan: Enter the project, create and activate virtual env, and: ``` $ pip install -r requirements.txt $ mypy . ``` Goal is to remove as many as I can to make it easier to confidently add new functionality
Contributor
Author
|
Most of the remaining typing errors are from returning data from a |
jjjonesjr33
added
In review
jjjonesjr33
added
Canceled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan: Enter the project, create and activate virtual env, and:
Goal is to remove as many as I can to make it easier to confidently add new functionality.