Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Lid Mode, Lid Speed, and Lid Close Time for OneRFIDSmartFeeder PLAF301 #55

Merged
merged 43 commits into from
Jan 18, 2025
Merged

Add Support for Lid Mode, Lid Speed, and Lid Close Time for OneRFIDSmartFeeder PLAF301 #55

merged 43 commits into from
Jan 18, 2025

Conversation

C4-Dimitri
Copy link
Contributor

@C4-Dimitri C4-Dimitri commented Jan 18, 2025 •
edited
Loading

Add Support for Lid Mode, Lid Speed, and Lid Close Time for OneRFIDSmartFeeder PLAF301

Support for changing devices lid mode, from Keep Open to Personal Mode or Vice Versa:
image
Support for changing devices lid speed (opening and closing speed, how fast the physical mechanism moves, not how long it takes to start moving):
image
Support for changing devices lid close time (how long before it starts closing after no longer detecting pet):
image

Closes #51 Closes #28

Type of change

  • [ X] New feature or enhancement (non-breaking change which adds functionality).

Checklist:

  • [ X] If applicable, I have added corresponding documentation changes.
  • [ X] If applicable, I have reviewed the feature / enhancement guidlines before submitting my request.
  • [ X] If applicable, I have tested my code for new features & regressions on the latest version of Home Assistant.

@C4-Dimitri
Test Manual Lid Opening
848891c
@C4-Dimitri
With correct description for def, and with missing comma.
7cf2966
@C4-Dimitri
Try without in line comment - and Bool True
1d13d81
@C4-Dimitri
Test Display Matrix Buttons
4eb55ab
@C4-Dimitri
Merge pull request #1 from C4-Dimitri/display_matrix_dev
032f19a 
Test Display Matrix Buttons
@C4-Dimitri
Better Endpoint to get data, data is already in seconds, no need to c…
9aa7cba 
…onvert.
@C4-Dimitri
Test Sound + Shorter Names For Display
9b0f9b3
@C4-Dimitri
With Corrected soundEndTime
3a66ac6
@C4-Dimitri
Now sending to the correct endpoint...
b5c72ad
@C4-Dimitri
Merge branch 'jjjonesjr33:master' into master
fa89736
@C4-Dimitri
Merge branch 'jjjonesjr33:master' into master
a35a3ec
@C4-Dimitri
Test 1st real commit on this.
a958849
@C4-Dimitri
Remove device class from select entity as its superfluous.
65e31ec
@C4-Dimitri
switch order to ensure defaults are after none defaults.
f7a5de3
@C4-Dimitri
switch order again...
bd06867
@C4-Dimitri
Change order of a few things and dont assign a default to current_opt…
c329597 
…ion.
@C4-Dimitri
try and make the other dataclasses non-default.
7f614eb
@C4-Dimitri
try with list rather than List
714bf2d
@C4-Dimitri
test again
0eb9efb
@C4-Dimitri
try and rename options to see if it interferes.
db01a84
@C4-Dimitri
test
c068c12
@C4-Dimitri
lets try with naming them a custom name.
814ae50
@C4-Dimitri
test with select in init
9ca48cd
@C4-Dimitri
Test
7f0d114
@C4-Dimitri
Test Again
a96c45c
@C4-Dimitri
Test new order again...
2ddf2a6
@C4-Dimitri
try making all non-required.
8fb2c41
@C4-Dimitri
test again
19d323f
@C4-Dimitri
Now with options included.
8a4ebc0
@C4-Dimitri
Test setting from initilization
48d61c3
@C4-Dimitri
Copy link
Contributor Author

FYI - if you want we can change the name of the modes to what they are called in the App. i just didnt find those names to be very descriptive. like What the hell does Personal Mode mean lol

@jjjonesjr33 jjjonesjr33 self-assigned this Jan 18, 2025
@jjjonesjr33 jjjonesjr33 added the Enhancement New feature or request label Jan 18, 2025
@jjjonesjr33
Updated select.py
e8f39af 
Changed wording to match app, but also leave descriptive
@jjjonesjr33
Updated one_rfid_smart_feeder.py
fc77fd7 
matched app and added descriptive text
@jjjonesjr33
Update en.json
3d71426 
updated translations
@jjjonesjr33
Update de.json
c1bde77 
updated translations
@jjjonesjr33
Update en.json
1bd0e13 
fixed spacing
jjjonesjr33
jjjonesjr33 previously approved these changes Jan 18, 2025
View reviewed changes
Copy link
Owner

@jjjonesjr33 jjjonesjr33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I made some small changes to keep it similar to the app but still be descriptive. Also updated the translations to match.

@jjjonesjr33 jjjonesjr33 added the Completed Completed tasks label Jan 18, 2025
@jjjonesjr33
Update de.json
0fdc37f 
reverting, error with validation
@C4-Dimitri
Copy link
Contributor Author

Looks good, I made some small changes to keep it similar to the app but still be descriptive. Also updated the translations to match.

Sure, have no problem with that, all i'd note is that there is limited space to see the text on mobile. But even with the new length it should be ok.

@jjjonesjr33
Update en.json
38b87ab 
reverting, error with validation
jjjonesjr33
jjjonesjr33 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Owner

@jjjonesjr33 jjjonesjr33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jjjonesjr33 jjjonesjr33 merged commit deba321 into jjjonesjr33:dev Jan 18, 2025
1 check passed
@jjjonesjr33
Copy link
Owner

jjjonesjr33 commented Jan 18, 2025 •
edited
Loading

You know on mobile it actually looks pretty good to @C4-Dimitri

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjjonesjr33 jjjonesjr33 jjjonesjr33 approved these changes

Assignees

@jjjonesjr33 jjjonesjr33

Labels
Completed Completed tasks Enhancement New feature or request
Projects
Petlibro
Status: Done
Milestone
[Features]: One RFID Smart Feeder (PL...
2 participants
@C4-Dimitri @jjjonesjr33