Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Setting the Manual Feed Amount for Air Smart Feeders #63

Merged
merged 23 commits into from
Jan 27, 2025

Conversation

Nistp
Copy link
Contributor

@Nistp Nistp commented Jan 21, 2025

Proposed change:

This PR adds the support for setting the manual feed/dispense amount for Petlibro Air Smart Feeders.

Attached are the pictures of the button object and then a validation of the implementation.

firefox_Av905IpF8c

firefox_OoVjAWSrAg

firefox_If02bSog92

IMG_2276

Closes #33

Type of change:

  • New device.
  • Bug fix (non-breaking change which fixes an issue).
  • New feature or enhancement (non-breaking change which adds functionality).
  • Documentation only.
  • Other (please explain).

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature / enhancement guidelines before submitting my request.
  • If applicable, I have tested my code for new features & regressions on the latest version of Home Assistant.

Additional notes:

Nistp and others added 9 commits November 30, 2024 21:22
Edited air_smart_feeder.py and api.py
…mber scale.

-Added a in-class variable that represents the manual feed quantity in air_smart_feeder.py

- Changed the set_manual_feed method in air_smart_feeder.py to accomadate passing in the new variable

-Changed the set_manual_feed function in api.py to allow to pass the new variable into the api-driven web-request

-Added a number entity to represent the manual feed quantity in number.py
@jjjonesjr33 jjjonesjr33 added the In review Pending review label Jan 21, 2025
@jjjonesjr33
Copy link
Owner

@Nistp I'll give this a test a little later today when I can. Based upon what I see we should be able to expand this to the other feeders as well. Great work!

@jjjonesjr33
Copy link
Owner

Don't mind me if you're getting notifications about edits/changes atm to your post @Nistp Was doing a change on my side for how GitHub sends webhooks to my server 😄

image

@rhenschen
Copy link

Any updates on this being updated to the update integration looks like you are close.

@jjjonesjr33
Copy link
Owner

@Nistp there's a small bug I am working out on my side with this. Whenever it loads it defaults to unknown until you set it.

But good news is I was able to get it to work with the other devices. I'll get your push updated with the code once I finish up the testing.

Copy link
Owner

@jjjonesjr33 jjjonesjr33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the changes this now works for all devices and looks good. @Nistp if you would pull a copy and do a test run on your side just to confirm.

Thanks 😃

@Nistp
Copy link
Contributor Author

Nistp commented Jan 27, 2025

@jjjonesjr33 yeah, it worked fine for me! I currently only have Air Smart Feeders, but it works for them, yep!

@jjjonesjr33 jjjonesjr33 merged commit d663e3d into jjjonesjr33:dev Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In review Pending review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Change grain amount for manual Feed
3 participants