Footer issues (#5)

more self vs this issues!
jkanche · Nov 2, 2023 · 80a853f · 80a853f
1 parent b8577aa
commit 80a853f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ridges.js",
-  "version": "0.0.6",
+  "version": "0.0.7",
   "description": "Create and visualize ridge plots",
   "repository": "https://github.com/jkanche/ridges.js",
   "homepage": "https://github.com/jkanche/ridges.js#readme",

diff --git a/src/HorizontalRidgePlot.js b/src/HorizontalRidgePlot.js
@@ -55,6 +55,10 @@ export class HorizontalRidgePlot extends RidgePlot {
 
     let self = this;
 
+    self._width = width;
+    self._height = height;
+    self._margin = margin;
+
     if (this.elem.querySelector("svg")) {
       this.elem.querySelector("svg").innerHTML = "";
     }

diff --git a/src/RidgePlot.js b/src/RidgePlot.js
@@ -136,8 +136,8 @@ export class RidgePlot {
       svg
         .append("text")
         .attr("text-anchor", "end")
-        .attr("x", width)
-        .attr("y", height + margin.bottom)
+        .attr("x", this._width)
+        .attr("y", this._height + this._margin.bottom)
         .style("font-size", "10px")
         .style("font-style", "italic")
         .text(this.state.footer);

diff --git a/src/VerticalRidgePlot.js b/src/VerticalRidgePlot.js
@@ -51,6 +51,10 @@ export class VerticalRidgePlot extends RidgePlot {
     height = height - margin.top - margin.bottom;
     let self = this;
 
+    self._width = width;
+    self._height = height;
+    self._margin = margin;
+
     if (this.elem.querySelector("svg")) {
       this.elem.querySelector("svg").innerHTML = "";
     }