-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIGTERM support for graceful shutdown #13
SIGTERM support for graceful shutdown #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @0kate , I added a few small change requests. Let me know if you are okay with them.
@jkfran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! @0kate
Description of the changes
kill
command)-s
/--signal
option to specify signal type.killport -s sigterm 8080
-s sigterm
option for graceful shutdown.Related issue(s)
This PR is related to the issue #8.
But this is not completely support for all signal types.
Type of change
Please select one or multiple of the following options:
Checklist:
Additional information
Add any other information or screenshots about the pull request here.