-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop docker containers on linux #18
Stop docker containers on linux #18
Conversation
ff9b5f7
to
bad27f5
Compare
I don't think that this commit really needs to introduce the anyhow crate from the looks of your changes all the errors already have some sort of mapping to std::io::Error and those that can't can just use the ErrorKind::Other from your usages it might be worth just mapping your errors into io errors instead of adding an extra crate |
Hi @0kate, thank you so much for the contribution! Would it be possible to eliminate all the About anyhow, I agree with the previous comment. In our case, we're only dealing with std::io::Error and a few other error types that can be easily converted to std::io::Error. It might be simpler and more consistent to stick with std::io::Error. |
@jacobtread @jkfran It's okay about eliminating |
eca3fa8
to
25626a1
Compare
@jkfran |
3b7f2c9
to
b556203
Compare
Hey I'd love to see this landed, any other changes needed? |
Description of the changes
Killable
trait for abstraction layer to implement stopping native processes and docker containers.anyhow
・・・ for easier generic error handlingbollard
・・・for docker client in rusttokio
・・・for asynchronous runtime (because thebollard
is only supported tokio runtime currently)Sorry for some huge changes. 🙏
Related issue(s)
If this PR is related to an existing issue, please link to it using the
Fixes #issue_number
orCloses #issue_number
syntax.Type of change
Please select one or multiple of the following options:
Checklist:
Additional information
Add any other information or screenshots about the pull request here.