Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for remaining signals #22

Merged
merged 5 commits into from
May 15, 2024

Conversation

NachiketNamjoshi
Copy link
Contributor

Description of the changes

  • Adds support to send all signals available in nix::sys::signal::Signal and works with the same -s option.
  • Refactored integration_test.rs

Related issue(s)
Improves on #8

Type of change
Please select one or multiple of the following options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup (refactoring or improving code quality)
  • Documentation update (adding or updating documentation, updating README)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jkfran
Copy link
Owner

jkfran commented May 12, 2023

Thank you! Could you format the code with cargo fmt --all?

Adds support to send all signals available in `nix::sys::signal::Signal`

✅ Closes: jkfran#8

Signed-off-by: NachiketNamjoshi <[email protected]>
Signed-off-by: NachiketNamjoshi <[email protected]>
@NachiketNamjoshi
Copy link
Contributor Author

I ran cargo fmt --all. Please, verify.

@jkfran jkfran merged commit 6f9d6d5 into jkfran:main May 15, 2024
2 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants