Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows changes #25

Merged
merged 6 commits into from
Jul 25, 2023
Merged

Conversation

jacobtread
Copy link
Contributor

Description of the changes
Please provide a clear and concise description of the changes you made.

Pretty big cleanup of the whole windows side of things

Fixed and cleaned up some memory allocations. Memory for the extended tables wasn't be fully deallocated and the initialize size allocation was ignored so it would reallocate regardless of fit. (All previous issues were fixed)

Looks like in the original I forgot to close the process handle after terminating so that's done here as well

I've moved things to a more generic angle the different IP and Protocols now use the same shared function for loading the extended tables and then the implementation for reading from them is a trait implementation for the specific type

Related issue(s)
If this PR is related to an existing issue, please link to it using the Fixes #issue_number or Closes #issue_number syntax.

Type of change
Please select one or multiple of the following options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup (refactoring or improving code quality)
  • Documentation update (adding or updating documentation, updating README)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Additional information
Apologies for the previously mentioned issues haven't really worked with Windows APIs before so this was my first time working with them

Copy link
Owner

@jkfran jkfran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@jkfran jkfran merged commit 24e53f4 into jkfran:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants