Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Please provide a clear and concise description of the changes you made.
Pretty big cleanup of the whole windows side of things
Fixed and cleaned up some memory allocations. Memory for the extended tables wasn't be fully deallocated and the initialize size allocation was ignored so it would reallocate regardless of fit. (All previous issues were fixed)
Looks like in the original I forgot to close the process handle after terminating so that's done here as well
I've moved things to a more generic angle the different IP and Protocols now use the same shared function for loading the extended tables and then the implementation for reading from them is a trait implementation for the specific type
Related issue(s)
If this PR is related to an existing issue, please link to it using the
Fixes #issue_number
orCloses #issue_number
syntax.Type of change
Please select one or multiple of the following options:
Checklist:
Additional information
Apologies for the previously mentioned issues haven't really worked with Windows APIs before so this was my first time working with them