-
Notifications
You must be signed in to change notification settings - Fork 1
feat(container)!: Update docker.io/mariadb ( 11.4.8 → v12 ) #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughUpdated MariaDB container image tag from version 11.4.8 to 12.1.2 in the BookStack MediaServer HelmRelease. Single-line configuration change with no modifications to environment variables, probes, or resource specifications. Changes
|
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | Title accurately reflects the primary change: MariaDB container image major version bump from 11.4.8 to v12 (specifically 12.1.2). Clear, specific, and highlights the breaking change nature. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
- 📝 Generate docstrings
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
renovate/docker.io-mariadb-12.x
Comment @coderabbitai help to get the list of available commands and usage tips.
ℹ️ SOPS Encryption CheckNo SOPS files detected in this pull request.
No encryption validation required for this PR. |
✅ Gitleaks Secret Scan PassedNo secrets detected in this pull request.
|
--- HelmRelease: media/bookstack-mariadb-standalone Deployment: media/bookstack-mariadb-standalone
+++ HelmRelease: media/bookstack-mariadb-standalone Deployment: media/bookstack-mariadb-standalone
@@ -52,13 +52,13 @@
value: bookstack
- name: TZ
value: America/New_York
envFrom:
- secretRef:
name: bookstack-mariadb-standalone
- image: docker.io/mariadb:11.4.8
+ image: docker.io/mariadb:12.1.2
livenessProbe:
exec:
command:
- healthcheck.sh
- --connect
- --innodb_initialized |
--- kubernetes/apps/media/bookstack/app Kustomization: media/bookstack HelmRelease: media/bookstack-mariadb-standalone
+++ kubernetes/apps/media/bookstack/app Kustomization: media/bookstack HelmRelease: media/bookstack-mariadb-standalone
@@ -45,13 +45,13 @@
TZ: America/New_York
envFrom:
- secretRef:
name: bookstack-mariadb-standalone
image:
repository: docker.io/mariadb
- tag: 11.4.8
+ tag: 12.1.2
probes:
liveness:
custom: true
enabled: true
spec:
exec: |
- Update LinuxServer regex to handle -r{N}-ls{N} format (qBittorrent)
- Change Home Assistant from loose to regex versioning (excludes dev/beta)
- Fix qBittorrent tag: 5.1.4 → 5.1.4-r1-ls431 (proper stable format)
Fixes false major PRs: #630 (qBittorrent), #628 (Home Assistant)
Stale PRs to close: #631 (Sonarr), #630
Valid majors to review: #629 (Uptime Kuma), #627 (Homepage), #626 (MariaDB)
) * fix(renovate): address versioning gaps causing false major updates - Update LinuxServer regex to handle -r{N}-ls{N} format (qBittorrent) - Change Home Assistant from loose to regex versioning (excludes dev/beta) - Fix qBittorrent tag: 5.1.4 → 5.1.4-r1-ls431 (proper stable format) Fixes false major PRs: #630 (qBittorrent), #628 (Home Assistant) Stale PRs to close: #631 (Sonarr), #630 Valid majors to review: #629 (Uptime Kuma), #627 (Homepage), #626 (MariaDB) * fix(renovate): add stable-only versioning for non-LinuxServer images - Uptime Kuma: exclude beta/nightly/variants (alpine, slim, rootless) - MariaDB: exclude RC and platform variants (noble, ubi) - Homepage: explicit v-prefixed semver matching Ensures only production-ready releases are proposed for updates. * fix(renovate): add MariaDB to database wait rule per CodeRabbit feedback * fix(renovate): resolve MariaDB rule conflict - add safety settings to versioning rule
6a388f1 to
07caa86
Compare
07caa86 to
fa89e5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
kubernetes/apps/media/bookstack/app/mariadb-helmrelease.yaml (1)
2-4: Update header comment to match 12.1.2.The header still references 11.4.8; please keep it aligned with the actual image tag.
📝 Suggested tweak
-# Standalone MariaDB 11.4.8 for BookStack -# Uses official MariaDB image for exact version match with source data -# Source DB: MariaDB 11.4.8 (from VM 101 docker-sandbox2) +# Standalone MariaDB 12.1.2 for BookStack +# Uses official MariaDB image for exact version match with source data +# Source DB: MariaDB 12.1.2 (from VM 101 docker-sandbox2)
🤖 Fix all issues with AI agents
In `@kubernetes/apps/media/bookstack/app/mariadb-helmrelease.yaml`:
- Around line 27-31: The HelmRelease bumps MariaDB to tag "12.1.2" but you must
verify incompatible changes: review MariaDB 12.1.2 changelog for MDEV items
affecting BookStack queries, audit my.cnf for removed/renamed options per the
"Incompatible Changes" docs, and plan to run mariadb-upgrade and full
backup/restore tests on staging before promoting (address any SQL or config
incompatibilities found). Also update the header comments that still reference
"11.4.8" to "12.1.2" so the file header matches the image tag, and document the
pre-deploy test plan/results in the PR notes.
| image: | ||
| repository: docker.io/mariadb | ||
| # renovate: datasource=docker depName=docker.io/mariadb versioning=semver | ||
| tag: 11.4.8 | ||
| tag: 12.1.2 | ||
| env: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
cat -n kubernetes/apps/media/bookstack/app/mariadb-helmrelease.yamlRepository: jlengelbrecht/prox-ops
Length of output: 3930
🌐 Web query:
MariaDB 12.1.2 release notes breaking changes from 11.4 upgrade
💡 Result:
Short answer: MariaDB 12.1.2’s release notes do not list a dedicated “breaking changes when upgrading from 11.4” section — the 12.1.2 notes focus on new features, bugfixes and individual changelog items (see release notes and changelog). You must therefore treat the upgrade as a major-version upgrade and follow the usual incompatible-change checks (remove/rename deprecated config options, run mariadb-upgrade, and verify mysql system tables and any table-format changes). Key references:
- MariaDB 12.1.2 release notes / changelog (no single “upgrade-from-11.4 breaking changes” list; lists individual changes such as removal of @@new_mode=FIX_INDEX_STATS_FOR_ALL_NULLS and other MDEV items). [1][2]
- MariaDB upgrade documentation and “Incompatible Changes” for major upgrades (examples of removed options that must be removed from my.cnf when upgrading to 11.4 — same principle applies when moving between major releases; run mariadb-upgrade and review incompatible-options). [3][4]
- Downgrade is not supported between major versions; verify mysql schema and on-disk format changes before upgrade. [5]
Recommended action before upgrading 11.4 → 12.1.2:
- Read the 12.1.2 release notes + changelog for any MDEV items that affect features you use (search the changelog for relevant MDEV IDs). [1][2]
- Review the “Incompatible Changes”/upgrade docs and remove deprecated/removed options from your config (example list shown in 11.4 docs). [3]
- Backup data, run mariadb-upgrade after starting the new server, and test on staging (downgrade between majors is unsupported). [4][5]
Sources:
[1] MariaDB 12.1.2 Release Notes.
[2] MariaDB 12.1.2 Changelog.
[3] Upgrade / Incompatible changes (example: Upgrade to 11.4 — removed/renamed options).
[4] mariadb-upgrade documentation.
[5] Downgrading between major versions (not supported).
Major MariaDB bump (11.4.8 → 12.1.2): verify incompatible changes and plan pre-deployment testing.
MariaDB 12.1.2 has no single "breaking changes" guide; you must review the 12.1.2 changelog for MDEV items affecting BookStack's queries and audit my.cnf for removed/renamed options in the Incompatible Changes documentation. Run mariadb-upgrade after upgrading and test backup/restore on staging—downgrade between major versions is unsupported.
Additionally, lines 2-4 still reference MariaDB 11.4.8 in the header comments; update them to reflect 12.1.2.
🤖 Prompt for AI Agents
In `@kubernetes/apps/media/bookstack/app/mariadb-helmrelease.yaml` around lines 27
- 31, The HelmRelease bumps MariaDB to tag "12.1.2" but you must verify
incompatible changes: review MariaDB 12.1.2 changelog for MDEV items affecting
BookStack queries, audit my.cnf for removed/renamed options per the
"Incompatible Changes" docs, and plan to run mariadb-upgrade and full
backup/restore tests on staging before promoting (address any SQL or config
incompatibilities found). Also update the header comments that still reference
"11.4.8" to "12.1.2" so the file header matches the image tag, and document the
pre-deploy test plan/results in the PR notes.
This PR contains the following updates:
11.4.8→12.1.2Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
🐘 MariaDB: Major versions may have breaking SQL syntax or config changes. Review release notes carefully before merging.
🐄 Talos CATTLE: Major/minor version requires manual approval. Full VM rebuild via Terraform.
Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.