Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nonlinear transformations #12

Merged
merged 5 commits into from
May 9, 2020

Conversation

sumanthratna
Copy link
Collaborator

@sumanthratna sumanthratna commented Apr 26, 2020

  • non_parametric: functional
  • bspline: functional
  • wendland: functional

Decreasing the learning rate solves the issue of the loss of microarchitectural details (airlab-unibas/airlab#26). Further experimentation with parameters may be necessary.

Constant flow raises an error about the interpolation method.
@jlevy44
Copy link
Owner

jlevy44 commented May 8, 2020

#6 I think this looks good enough to merge, just going to validate with a test.

@sumanthratna sumanthratna marked this pull request as ready for review May 8, 2020 21:09
@sumanthratna
Copy link
Collaborator Author

Nonparametric

python pathflow_mixmatch/cli.py register_images --im1 ./COAD_19_5pc.jpg --im2 ./COAD_19_5pc_S1.jpg --output_dir non_parametric/ --gpu_device 1 --transform_type non_parametric --no_segment_analysis True --verbose True --overwrite True --loss_fn ncc --lr 0.00001

B-spline

python pathflow_mixmatch/cli.py register_images --im1 ./COAD_19_5pc.jpg --im2 ./COAD_19_5pc_S1.jpg --output_dir bspline/ --gpu_device 1 --transform_type bspline --no_segment_analysis True --verbose True --overwrite True --loss_fn ncc --lr 0.00001

Wendland

python pathflow_mixmatch/cli.py register_images --im1 ./COAD_19_5pc.jpg --im2 ./COAD_19_5pc_S1.jpg --output_dir wendland/ --gpu_device 1 --transform_type wendland --no_segment_analysis True --verbose True --overwrite True --loss_fn ncc --lr 0.00001

@jlevy44
Copy link
Owner

jlevy44 commented May 9, 2020

Excellent, thanks!

@sumanthratna sumanthratna changed the title WIP: Fix nonlinear transformations Fix nonlinear transformations May 9, 2020
@jlevy44
Copy link
Owner

jlevy44 commented May 9, 2020

Hey so I'm testing right now. Seems like nonlinear transforms run out of memory very quickly (32GB GPU). I'm running an affine transformation right now and all linear transforms seem to be okay

@jlevy44
Copy link
Owner

jlevy44 commented May 9, 2020

I think part of it is in the create_image_pyramids, airlab-unibas/airlab#29 which I have tried to remedy here: https://github.com/jlevy44/airlab . Still too much memory.

@jlevy44
Copy link
Owner

jlevy44 commented May 9, 2020

So still memory issues. I'm going to merge here and then open up a new PR. @sumanthratna I've added you as a collaborator so feel free to open additional branches in this repo.

@jlevy44 jlevy44 merged commit 3334417 into jlevy44:master May 9, 2020
@jlevy44
Copy link
Owner

jlevy44 commented May 9, 2020

In any case, it was functional and thus should have been merged anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants