Skip to content

Commit

Permalink
remove Arm-unfriendly smooth knn failure test
Browse files Browse the repository at this point in the history
  • Loading branch information
jlmelville committed Jun 26, 2023
1 parent a8d88c5 commit 731abec
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 17 deletions.
8 changes: 8 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ There is one NOTE:

This is due to the underlying C++ implementation using templates.

## Package Check Problems

* There is a NOTE: `Specified C++11: please drop specification unless essential`
-- this has been fixed with this submission.

* There is an `M1mac` test failure <https://www.stats.ox.ac.uk/pub/bdr/M1mac/uwot.out>
-- this has been fixed with this submission.

## Downstream dependencies

We checked all 32 CRAN reverse dependencies, comparing R CMD check results
Expand Down
17 changes: 0 additions & 17 deletions tests/testthat/test_smooth_knn_dists.R
Original file line number Diff line number Diff line change
Expand Up @@ -266,23 +266,6 @@ sknn4m <- smooth_knn_matrix(nn_4)$matrix
expect_equal(sknn4m@x, expected_sknn4m@x, tol = 1e-7)
expect_equal(sknn4m@i, expected_sknn4m@i)

test_that("sigma and failures agree with Python UMAP (mainly)", {
# #100: this test fail Ubuntu/Debian testing on:
# arm64 (Sys.info()[["sysname"]] == "Linux", R.version$arch == "aarch64")
# ppc64le (Sys.info()[["sysname"]] == "Linux", R.version$arch == "powerpc64le")
# s390x (Sys.info()[["sysname"]] == "Linux", R.version$arch == "s390x")
skip_on_os("linux", arch = c("aarch64", "powerpc64le", "s390x"))

# UMAP Python disagrees for sigma[6] because binary search fails here and uwot
# keeps track of the "best" sigma
sknn4m <- smooth_knn_matrix(nn_4, ret_sigma = TRUE, bandwidth = 0.5)
expect_equal(sknn4m$sigma, c(0.00195312, 0.0078125 , 0.00097656, 0.00390625, 0.00390625,
0.0019531250, 0.00390625, 0.00390625, 0.0078125 , 0.0078125))
# for Python UMAP sigma[6] == 0.00048322
expect_equal(sknn4m$rho, expected_rho, tol = 1e-7)
expect_equal(sknn4m$n_failures, 1)
})

nn4sp <- Matrix::drop0(matrix(c(
0, 0, 0, 0, 0.1414214,0.6164414,0, 0.1732051,0, 0,
0, 0, 0.3000000,0, 0, 0, 0, 0, 0.5099020,0.1732051,
Expand Down

0 comments on commit 731abec

Please sign in to comment.