Replace hardcoded Kraken values with LUT parsing, Non-numeric value compatibility for Corsair Link and likes #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jan K. Marucha <[email protected]>
…ompatibility for Corsair Link and likes (#2) * Compatibility with non-numeric values returned by liquidctl, such as Corsair Link devices * Remove hardcoded Kraken X62 values, create generic LUT parser capabilities * Make failed status reads mroe error tolerant --------- Co-authored-by: Jan K. Marucha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jmarucha, I've made some further improvements, I couldn't stand my dirty hack for the RPM so made it a bit more dynamic. I also resolved some issues with Corsair Link devices based on my friend's input. How would you feel about merging this?