[WIP] Add sensor to estimate energy put in device and force offpeak if needed #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Huuum interesting addition. i wonder if it is better for an EV to consider the remaining energy (and not what have been added during the day). A user will need to have a certain amount of energy in the morning, and if not start the charging. |
Owner
|
Hello @lexyan , you start this PR 3 month ago. Do you intend to finish it or do you abandon it finally ? |
Owner
|
Hello, is this PR stale ? Did you abandon it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For power managed device, the on time is not sufficent to check if the device has enought energy at offpeak time.
For example, charging EV at 1 amp for 12h is not the same than charging at 16 amps for 12h even if the on_time is the same.
Adding an estimation of energy and a new threshold setting for force offpeak time.
TODO :