Add support for multiple off-peak time slots and entity-based detection #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds two new ways to configure off-peak hours: 1. Time ranges format: Allows specifying multiple time slots using a comma-separated format like "13:00-14:00,22:00-06:00" (similar to printer page selection) 2. Entity-based detection: Allows using a binary_sensor, input_boolean, sensor, or calendar entity to dynamically determine off-peak periods. When the entity state is 'on', it's considered off-peak time. The legacy single time format (e.g., "23:00") remains fully supported for backward compatibility. Changes: - Add CONF_OFFPEAK_ENTITY_ID constant and time range parsing utilities - Update config schema to accept both new options - Refactor should_be_forced_offpeak to use new _is_currently_offpeak method - Add is_offpeak property for easy status checking - Update strings.json with new field descriptions - Add comprehensive tests for new functionality
Owner
|
Hello @Le-Syl21, thank you for this ! I will look at your PR later because I have many work to do with the Versatile Thermostat at this moment. Be patient and thank you, this look like promising. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds two new ways to configure off-peak hours:
Time ranges format: Allows specifying multiple time slots using a comma-separated format like "13:00-14:00,22:00-06:00" (similar to printer page selection)
Entity-based detection: Allows using a binary_sensor, input_boolean, sensor, or calendar entity to dynamically determine off-peak periods. When the entity state is 'on', it's considered off-peak time.
The legacy single time format (e.g., "23:00") remains fully supported for backward compatibility.
Changes: