Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Add server filtering to table #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add server filtering to table #11

wants to merge 1 commit into from

Conversation

DanSweeney23
Copy link
Collaborator

No description provided.

@jmhobbs
Copy link
Owner

jmhobbs commented Apr 15, 2024

Rad! My only issue is that if you are selecting a filter and the table re-renders, it closes the select box 🙁

@DanSweeney23
Copy link
Collaborator Author

DanSweeney23 commented Apr 16, 2024

@jmhobbs Ah yeah you're right. I think the way to fix it will be to put a fixed row & select tags outside of the render function, like how the headers are made. The downside will be that if anything changes at vigrid, the filters will be wrong on the site until we update it manually. Maybe we could solve this by setting the options on the user's first load of the page and only re-rendering the options if the potential options change in the data. I won't have much time to implement that in the next few days but potentially could have a look next weekend.

@jmhobbs jmhobbs force-pushed the main branch 2 times, most recently from 1ae1c50 to 1e48316 Compare April 17, 2024 04:12
@jmhobbs
Copy link
Owner

jmhobbs commented Apr 17, 2024

I went ahead and implemented that. I made the filter lists additive, so they can add new values over time as the see them, but won't remove any. A refresh will reset it. The only wonky bit is the server status, but I didn't want to write special case code for that. Grabbed your select styles and plugged them in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants