Preview enhancements #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is not exported by the OSGI bundle and it is only used for the End of Line character
…lid or does not exist, a value of -1 is set instead of 0, as it is a valid preview value. Also, needed to remove the PREVIEW header when the message has a null-body as the PREVIEW is set to 0 in this case.
…y Termination to clear the PREVIEW header
…uest contains the full, complete body
eblocker
pushed a commit
to eblocker/netty-icap
that referenced
this pull request
Jan 15, 2020
…-1963-2008 to develop * commit '3db14b267e03f0e5ba6631eb0d05c98747c6d080': [EB1-1962] simplified logic [EB1-1963] replaced custom linked list implementation with java's [EB1-2008] added tests for 206 Partial Responses [EB1-1962] fixed merge error [EB1-2008] fixed encoding [EB1-2008] added support for icap 206 responses Fixed logic operator from bit-wise and to logical and Unset preview header on early terminated previews (simplified version of GlobalVelocity/netty-icap@5dbd992) Reset initial decoding state when initial line does not parse Fixed spelling in chunk toString methods Patch for ReadIcapHeaderState to accommodate malformed ICAP error messages Fixed bug in IcapHeaders.removeHeader where removing the last header messed up the head reference Improved Preview handling by removing the preview header when the request contains the full, complete body Fixed issue where the IcapChunkTrailer was not being checked for early Termination to clear the PREVIEW header Added support for 0 length preview. When the PREVIEW header is not valid or does not exist, a value of -1 is set instead of 0, as it is a valid preview value. Also, needed to remove the PREVIEW header when the message has a null-body as the PREVIEW is set to 0 in this case. Removed the dependency on org.jboss.netty.util.internal.StringUtil. It is not exported by the OSGI bundle and it is only used for the End of Line character
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I recently made some changes to
I have been doing my testing with squid3.1.19, that is where I uncovered the issues
(sorry for the whitespace diffs, that is intellij)
Thanks for all your work!