New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing letterOf and positionOf to use Arrays as lengthOf does #3188

Open

jguille2 wants to merge 1 commit into jmoenig:master from jguille2:lettersAndpositions

Contributor

jguille2 commented Feb 25, 2023

Hi!

It is related to #3183

If finally we keep current "Arrays operation" with "length of string" block, this PR fixes "letter of" and "position of" to be coherent with it.

"Letter of" is simple, because it's only adding that "Array.from(string)" pre-transformation.
"Position of" (from "strings" library) has more changes... We don't need any "JS primitive", but we have to consider our "blocks cases" to build a coherent operation (if a field is empty...)

There are more blocks affected, from "strings" and "word-sentence" libraries... but all based on "letterOf" and "positionOf" blocks

Because here (github PR) custom block changes are not easily shown, I paste that block here:


          Fixing letterOf and positionOf to use Arrays as lengthOf does

d2b286f

Collaborator

cycomachead commented Feb 25, 2023

Thanks! This LGTM. We should have done this a while ago. :)

aelnosu approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet