Fix small-screen profile picker navigation

[EyJunge1]

Summary

• Rebuild the display profile picker list from favorites plus all profiles in stable profile order.
• Start the picker on the currently selected profile instead of always index 0.
• Keep the "Current profile" label tied to the selected profile id and guard empty/out-of-range picker state.

Fixes #701

Test plan

• pio run -e display
• Manual device check with 5 profiles, Feature/steam mode #1/Steam Mode #2 favorited, select Show Bluetooth and WiFi status #3, reopen picker, navigate left to Steam Mode #2/Feature/steam mode #1.

Summary by CodeRabbit

• New Features

  • Profiles list now combines favorites with available profiles and reloads when switching, keeping the selected profile highlighted.

• Bug Fixes

  • Stronger bounds checks and default initialization prevent empty-state and out-of-range errors.
  • Profile labels and "next profile" control now correctly reflect available profiles and disable when at the end.

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please contact @jniebuhr (mdwasp) on Discord to get yourself added.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 05f24ba6-c658-426f-96d1-06c0e5152db7

📥 Commits

Reviewing files that changed from the base of the PR and between a0fd5a6 and a3d7ff9.

📒 Files selected for processing (1)

• src/display/ui/default/DefaultUI.cpp

🚧 Files skipped from review as they are similar to previous changes (1)

• src/display/ui/default/DefaultUI.cpp

---

📝 Walkthrough

Walkthrough

Rebuilds the profile ID list by merging favorites with all profiles, initializes currentProfileIdx to 0, reloads profiles before switching screens, and adds defensive bounds checks to navigation and profile-screen rendering.

Changes

Profile picker navigation and rendering safety

Layer / File(s)	Summary
Data initialization and dependencies src/display/ui/default/DefaultUI.h, src/display/ui/default/DefaultUI.cpp	currentProfileIdx initialized to 0 and <iterator> header added to support de-duplication in the refactored profile list construction.
Profile list construction with deduplication src/display/ui/default/DefaultUI.cpp	loopProfiles() rebuilds the backing ID list by merging favoritedIds with the full listProfiles() result, de-duplicating, reserving capacity, loading profiles for merged IDs, and initializing currentProfileIdx by matching the controller-selected profile id.
Navigation flow and bounds checking src/display/ui/default/DefaultUI.cpp	onProfileSwitch() reloads profiles before switching screens; onNextProfile() advances only when the list is non-empty and index < size - 1; onProfileSelect() early-returns when the favorites list is empty or currentProfileIdx is out-of-range.
Profile screen rendering with guards src/display/ui/default/DefaultUI.cpp	Profile screen update logic checks for empty or out-of-range currentProfileIdx before accessing favoritedProfiles, populates UI labels/values from the selected profile object, and derives "current vs select" from profile.id == selectedProfileId.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 I hopped through lists both near and far,
Merged favorites with the full profile tar,
Bounds checked every leap and stride,
Now back-and-forth works just right,
A merry picker, safe, on par.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing navigation issues in the small-screen profile picker.
Linked Issues check	✅ Passed	The code changes directly address all requirements from issue #701: rebuilding the profile list from favorites plus all profiles, starting on the selected profile, keeping navigation through all profiles, and guarding against empty/out-of-range states.
Out of Scope Changes check	✅ Passed	All changes are scoped to fixing the profile picker navigation issue; the addition of <iterator> header and initialization of currentProfileIdx are necessary supporting changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[EyJunge1]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud