Skip to content

Move to Pioarduino#759

Open
jniebuhr wants to merge 6 commits into
masterfrom
feature/pioarduino-move
Open

Move to Pioarduino#759
jniebuhr wants to merge 6 commits into
masterfrom
feature/pioarduino-move

fix(comms): re-send controller config after BLE reconnect (#786)

6b95001
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 11, 2026 in 1m 2s

Quality Gate passed

Issues
43 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 206 in src/display/core/Settings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a field "mdnsName" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNz2Wh4_BOS_Gj4d&open=AZ9RwNz2Wh4_BOS_Gj4d&pullRequest=759

Check warning on line 254 in src/display/plugins/WebUIPlugin.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the misleading "/*" characters. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNwVWh4_BOS_Gj4W&open=AZ9RwNwVWh4_BOS_Gj4W&pullRequest=759

Check warning on line 230 in src/display/core/Settings.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a global variable "timezone" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwN3ZWh4_BOS_Gj4r&open=AZ9RwN3ZWh4_BOS_Gj4r&pullRequest=759

Check warning on line 93 in src/display/plugins/WebUIPlugin.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove these redundant parentheses. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ67WuJcPTI3RoldgKZm&open=AZ67WuJcPTI3RoldgKZm&pullRequest=759

Check failure on line 12 in src/display/core/MemoryMonitor.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ67WuVHPTI3RoldgKZp&open=AZ67WuVHPTI3RoldgKZp&pullRequest=759

Check warning on line 48 in src/display/ui/default/DefaultUI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a field "error" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNtUWh4_BOS_Gj4I&open=AZ9RwNtUWh4_BOS_Gj4I&pullRequest=759

Check warning on line 226 in src/display/core/Settings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a field "savedScale" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNz2Wh4_BOS_Gj4g&open=AZ9RwNz2Wh4_BOS_Gj4g&pullRequest=759

Check warning on line 266 in src/display/core/Settings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a field "homeAssistantIP" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNz2Wh4_BOS_Gj4i&open=AZ9RwNz2Wh4_BOS_Gj4i&pullRequest=759

Check warning on line 341 in src/display/core/Controller.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwN2WWh4_BOS_Gj4p&open=AZ9RwN2WWh4_BOS_Gj4p&pullRequest=759

Check failure on line 88 in src/display/core/utils.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Global variables should be const. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ67WuVqPTI3RoldgKZq&open=AZ67WuVqPTI3RoldgKZq&pullRequest=759

Check warning on line 191 in src/display/core/Settings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a field "pumpModelCoeffs" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNz2Wh4_BOS_Gj4a&open=AZ9RwNz2Wh4_BOS_Gj4a&pullRequest=759

Check failure on line 1105 in src/display/core/Controller.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwN2WWh4_BOS_Gj4q&open=AZ9RwN2WWh4_BOS_Gj4q&pullRequest=759

Check warning on line 94 in src/display/core/Settings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Directly pass the arguments for object creation to this function. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNz2Wh4_BOS_Gj4Y&open=AZ9RwNz2Wh4_BOS_Gj4Y&pullRequest=759

Check warning on line 938 in src/display/ui/default/DefaultUI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto". 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNtUWh4_BOS_Gj4U&open=AZ9RwNtUWh4_BOS_Gj4U&pullRequest=759

Check warning on line 524 in src/display/ui/default/DefaultUI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 21 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNtUWh4_BOS_Gj4L&open=AZ9RwNtUWh4_BOS_Gj4L&pullRequest=759

Check failure on line 134 in src/display/plugins/HomekitPlugin.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ67WuQIPTI3RoldgKZn&open=AZ67WuQIPTI3RoldgKZn&pullRequest=759

Check failure on line 89 in src/display/core/Controller.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwN2WWh4_BOS_Gj4o&open=AZ9RwN2WWh4_BOS_Gj4o&pullRequest=759

Check failure on line 87 in src/display/core/Controller.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwN2WWh4_BOS_Gj4n&open=AZ9RwN2WWh4_BOS_Gj4n&pullRequest=759

Check warning on line 806 in src/display/ui/default/DefaultUI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid this unnecessary copy by using a "const" reference. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNtUWh4_BOS_Gj4R&open=AZ9RwNtUWh4_BOS_Gj4R&pullRequest=759

Check warning on line 309 in src/display/ui/default/DefaultUI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this function pointer with a template parameter or a "std::function". 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNtUWh4_BOS_Gj4J&open=AZ9RwNtUWh4_BOS_Gj4J&pullRequest=759

Check warning on line 271 in src/display/core/Settings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a field "homeAssistantPort" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNz2Wh4_BOS_Gj4j&open=AZ9RwNz2Wh4_BOS_Gj4j&pullRequest=759

Check warning on line 870 in src/display/ui/default/DefaultUI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a field "pressure" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNtUWh4_BOS_Gj4T&open=AZ9RwNtUWh4_BOS_Gj4T&pullRequest=759

Check warning on line 201 in src/display/core/Settings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a field "wifiPassword" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNz2Wh4_BOS_Gj4c&open=AZ9RwNz2Wh4_BOS_Gj4c&pullRequest=759

Check failure on line 767 in src/display/ui/default/DefaultUI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 43 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNtUWh4_BOS_Gj4P&open=AZ9RwNtUWh4_BOS_Gj4P&pullRequest=759

Check warning on line 811 in src/display/ui/default/DefaultUI.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this "if" statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=jniebuhr_gaggimate&issues=AZ9RwNtUWh4_BOS_Gj4Q&open=AZ9RwNtUWh4_BOS_Gj4Q&pullRequest=759
View more details on SonarQubeCloud