Skip to content

chore: remove deprecated standalone pages and routes#772

Open
Serokz wants to merge 3 commits into
jniebuhr:masterfrom
Serokz:pr-cleanup
Open

chore: remove deprecated standalone pages and routes#772
Serokz wants to merge 3 commits into
jniebuhr:masterfrom
Serokz:pr-cleanup

Conversation

@Serokz

@Serokz Serokz commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Following the successful integration of the tabbed Settings page (PR 4) and the unified Analysis hub (PR 5), this cleanup PR removes the deprecated standalone pages (OTA, Autotune, Scales, etc.) and deletes their legacy redirect routes.

What's Changed

  • Files Deleted: Removed web/src/pages/OTA/index.jsx, web/src/pages/Autotune/index.jsx, and web/src/pages/Scales/index.jsx.
  • Routing & Nav Cleanup: Cleaned up the lazy imports and router definitions in web/src/index.jsx to reduce chunk counts, leaving only the new unified routes.

This is the final phase of the frontend modernization and cleanup effort.

Summary by CodeRabbit

Release Notes

  • Removed Features
    • Removed PID autotune and Bluetooth devices sections from navigation
    • Removed Bluetooth scales scanning and connection features
    • Removed system updates management interface

@cla-bot cla-bot Bot added the cla-signed label Jun 14, 2026
@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 38b1761c-9b51-4262-98bc-2029212566a3

📥 Commits

Reviewing files that changed from the base of the PR and between 591abe7 and ea41d5d.

📒 Files selected for processing (6)
  • scripts/auto_firmware_version.py
  • web/src/components/Navigation.jsx
  • web/src/index.jsx
  • web/src/pages/Autotune/index.jsx
  • web/src/pages/OTA/index.jsx
  • web/src/pages/Scales/index.jsx
💤 Files with no reviewable changes (5)
  • web/src/index.jsx
  • web/src/pages/Autotune/index.jsx
  • web/src/pages/Scales/index.jsx
  • web/src/components/Navigation.jsx
  • web/src/pages/OTA/index.jsx

📝 Walkthrough

Walkthrough

Three web UI page components (OTA, Scales, Autotune) are deleted entirely. Their navigation entries, lazy-load declarations, and router routes are removed from Navigation.jsx and index.jsx. Separately, scripts/auto_firmware_version.py replaces datetime.UTC with datetime.timezone.utc for Python compatibility.

Changes

Web UI Page Removal

Layer / File(s) Summary
Navigation entries and route removal
web/src/components/Navigation.jsx, web/src/index.jsx, web/src/pages/OTA/index.jsx, web/src/pages/Scales/index.jsx, web/src/pages/Autotune/index.jsx
FontAwesome icon imports in Navigation.jsx are reduced to faCog; "PID Autotune", "Bluetooth Devices", and "System & Updates" nav items are removed. In index.jsx, lazy-load entries for OTA, Scales, and Autotune are replaced with ProfileList/ProfileEdit, and the /ota, /scales, and /pidtune routes are deleted. The three page component files (OTA, Scales, Autotune) are fully removed.

Firmware Build Script Fix

Layer / File(s) Summary
datetime.UTC compatibility fix
scripts/auto_firmware_version.py
get_time_specifier_build_flag() switches from datetime.UTC to datetime.timezone.utc for the UTC build timestamp.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 Hop, hop! Three pages gone away,
OTA, Scales, Autotune — cleared today.
The nav grows tidy, routes trimmed neat,
And timezone.utc makes the clock complete.
Less code to hop through — what a treat! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately summarizes the main change: removing deprecated standalone pages and routes, which is the primary objective described in the PR summary.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant