Skip to content

Fixes problems with build#781

Open
Shin-nn wants to merge 1 commit into
jniebuhr:masterfrom
Shin-nn:build_fixes
Open

Fixes problems with build#781
Shin-nn wants to merge 1 commit into
jniebuhr:masterfrom
Shin-nn:build_fixes

Conversation

@Shin-nn

@Shin-nn Shin-nn commented Jun 18, 2026

Copy link
Copy Markdown

No description provided.

@cla-bot

cla-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please contact @jniebuhr (mdwasp) on Discord to get yourself added.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3ea6d934-fac3-4de5-b1ee-94535d24a297

📥 Commits

Reviewing files that changed from the base of the PR and between 1b2fa74 and 8a6d162.

📒 Files selected for processing (5)
  • .github/workflows/build-nightly.yml
  • .github/workflows/build.yml
  • sim/platform/arduino/Print.cpp
  • src/display/core/utils.h
  • src/display/plugins/BLEScalePlugin.h
 ___________________________________________________________________
< This refactor is like rearranging furniture during an earthquake. >
 -------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Infer to find bugs in Java and C/C++ code.

Infer analyzes compiled code paths and reports issues such as null dereferences, resource leaks, and concurrency bugs.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant