Skip to content

feat: add configurable water level indicator dot#820

Open
hahny93 wants to merge 2 commits into
jniebuhr:masterfrom
hahny93:feat/water-level-toggle
Open

feat: add configurable water level indicator dot#820
hahny93 wants to merge 2 commits into
jniebuhr:masterfrom
hahny93:feat/water-level-toggle

Conversation

@hahny93

@hahny93 hahny93 commented Jul 11, 2026

Copy link
Copy Markdown

Summary

Added a configurable water level indicator dot to the display, visible on menu/info/profile and brew/steam/water screens when a ToF/Alba water sensor is connected.

Display:

  • 14px circle dot positioned at top center (Y=-230)
  • Shows only when ToF sensor is present and the setting is enabled
  • Uses sunriseIdle color when water level ≥20%, sunriseError color when low
  • Both colors are configurable via existing Alba sunrise settings in the web UI

Settings:

  • showWaterLevelDot toggle (default: on) in Settings → Machine → Alba Settings, below the External LED slider
  • Persisted as NVS property "wld"

Shows a colored dot on menu, brew, steam, and water screens
when a ToF water sensor is connected. Uses sunriseIdle color
when water level is OK, sunriseError when low.

Also sends sr_idle/sr_err sunrise colors via web UI status.
@cla-bot

cla-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kevin Hahn.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@hahny93, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9914d12f-5fa4-4256-af33-a272dc5efaa7

📥 Commits

Reviewing files that changed from the base of the PR and between 2026b81 and 996df63.

📒 Files selected for processing (7)
  • src/display/core/Settings.cpp
  • src/display/core/Settings.h
  • src/display/plugins/WebUIPlugin.cpp
  • src/display/ui/default/DefaultUI.cpp
  • src/display/ui/default/DefaultUI.h
  • web/src/pages/Settings/index.jsx
  • web/src/pages/Settings/tabs/MachineTab.jsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hahny93
hahny93 force-pushed the feat/water-level-toggle branch from cee3c3a to 4253d30 Compare July 11, 2026 23:59
@cla-bot

cla-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please contact @jniebuhr (mdwasp) on Discord to get yourself added.

@hahny93
hahny93 force-pushed the feat/water-level-toggle branch from 4253d30 to 996df63 Compare July 12, 2026 00:00
@cla-bot

cla-bot Bot commented Jul 12, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please contact @jniebuhr (mdwasp) on Discord to get yourself added.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant