Skip to content

Refactor ProfileForms: Add utility profile toggle and textarea for description#828

Open
Sartoric wants to merge 2 commits into
jniebuhr:masterfrom
Sartoric:feature/sartoric-edit-profile-textarea-description-utility-toggle
Open

Refactor ProfileForms: Add utility profile toggle and textarea for description#828
Sartoric wants to merge 2 commits into
jniebuhr:masterfrom
Sartoric:feature/sartoric-edit-profile-textarea-description-utility-toggle

Conversation

@Sartoric

@Sartoric Sartoric commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
  • Added utility profile toggle
  • Changed the input field for description to textarea
  • Extracted ProfileMainInformation into a new reusable component.
  • Updated ExtendedProfileForm and StandardProfileForm to use ProfileMainInformation.

Summary by CodeRabbit

  • New Features

    • Added a reusable profile information section to profile forms.
    • Users can edit the profile label, description, temperature, and utility setting.
    • Added accessibility labels to profile information controls.
  • Improvements

    • Standard and extended profile forms now provide a consistent profile information editing experience.

Sartoric added 2 commits July 17, 2026 19:59
…e ProfileMainInformation component

- Extracted `ProfileMainInformation` into a new reusable component.
- Updated `ExtendedProfileForm` and `StandardProfileForm` to use `ProfileMainInformation`.
- Added utility profile toggle
@cla-bot cla-bot Bot added the cla-signed label Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

Profile information forms

Layer / File(s) Summary
Shared profile information component
web/src/pages/ProfileEdit/ProfileMainInformation.jsx
Adds controlled title, description, temperature, and utility fields with validation constraints and accessibility labels.
Profile form integrations
web/src/pages/ProfileEdit/ExtendedProfileForm.jsx, web/src/pages/ProfileEdit/StandardProfileForm.jsx
Replaces duplicated inline profile information cards with ProfileMainInformation and delegates field updates to existing handlers.

Estimated code review effort: 3 (Moderate) | ~15–30 minutes

Suggested reviewers: jniebuhr

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main form refactor and highlights the new utility toggle and textarea change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
13.8% Duplication on New Code (required ≤ 4%)

See analysis details on SonarQube Cloud

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
web/src/pages/ProfileEdit/ProfileMainInformation.jsx (1)

4-4: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Remove the debugging statement.

The console.log appears to be a leftover debugging artifact and should be removed.

♻️ Proposed fix
 export function ProfileMainInformation(props) {
-  console.log(props.data);
   return (
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@web/src/pages/ProfileEdit/ProfileMainInformation.jsx` at line 4, Remove the
debugging console.log(props.data) statement from the ProfileMainInformation
component, leaving the surrounding component logic unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@web/src/pages/ProfileEdit/ProfileMainInformation.jsx`:
- Line 4: Remove the debugging console.log(props.data) statement from the
ProfileMainInformation component, leaving the surrounding component logic
unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 71327a1f-d826-4e7d-8f94-ac8ed21cb9ef

📥 Commits

Reviewing files that changed from the base of the PR and between 48ce933 and 705652c.

📒 Files selected for processing (3)
  • web/src/pages/ProfileEdit/ExtendedProfileForm.jsx
  • web/src/pages/ProfileEdit/ProfileMainInformation.jsx
  • web/src/pages/ProfileEdit/StandardProfileForm.jsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant