Skip to content

Commit

Permalink
fixed compiler warnings (comparison of constant is always true, catch…
Browse files Browse the repository at this point in the history
…ing polymorphic type by value)
  • Loading branch information
jnsbyr committed Aug 22, 2023
1 parent 13542c1 commit ad22952
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/esp8266-intexsbh20/ConfigurationFile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ bool ConfigurationFile::load(const char* fileName)
configFile.close();
Serial.printf_P(PSTR("config file loaded successfully (has %d entries)\n"), configDoc.size());
}
catch (std::runtime_error re)
catch (const std::runtime_error& re)
{
Serial.println(re.what());
success = false;
Expand Down
2 changes: 1 addition & 1 deletion src/esp8266-intexsbh20/MQTTPublisher.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ void MQTTPublisher::loop()
publishIfDefined(MQTT_TOPIC::JET, pureSpaIO.isJetOn(), PureSpaIO::UNDEF::BOOL);
}

bool b = pureSpaIO.isHeaterOn();
uint8 b = pureSpaIO.isHeaterOn();
if (b != PureSpaIO::UNDEF::BOOL)
{
mqttClient.publish(MQTT_TOPIC::HEATER, b? (pureSpaIO.isHeaterStandby()? "standby" : "on") : "off", retainAll);
Expand Down
2 changes: 1 addition & 1 deletion src/esp8266-intexsbh20/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@

namespace CONFIG
{
const char WIFI_VERSION[] = "1.0.8.0"; // 19.08.2023
const char WIFI_VERSION[] = "1.0.8.1"; // 22.08.2023

// WiFi parameters
const unsigned long WIFI_MAX_DISCONNECT_DURATION = 900000; // [ms] 5 min until reboot
Expand Down

0 comments on commit ad22952

Please sign in to comment.