Change the extension syntax #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joajfreitas
temporarily deployed
to
github-pages
GitHub Actions
Inactive
We will now use:
```
impl protocol for Struct {
...
}
```
Before the extension block started with an identifier, basically any
word would fit. This meant that typos on high level blocks issued a very
confusing error messaged about how the syntax for an extend block was
wrong, even when the typo was on a struct or enum.
Another possible advantage is that now there's no different names for
the extension and its type. They will always be the same, hopefully this
will mean less confusion when debugging message definitions.
joajfreitas
force-pushed
the
adapt_extension_syntax
branch
from
ecf0e70
to
6637954
Compare
joajfreitas
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joajfreitas
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will now use:
Before the extension block started with an identifier, basically any word would fit. This meant that typos on high level blocks issued a very confusing error messaged about how the syntax for an extend block was wrong, even when the typo was on a struct or enum.
Another possible advantage is that now there's no different names for the extension and its type. They will always be the same, hopefully this will mean less confusion when debugging message definitions.
resolves #65