Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug separating multiple values when printing #590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bo-tato
Copy link

@bo-tato bo-tato commented Apr 17, 2023

slynk-pprint-values forgets to pass the stream to terpri when it prints a newline between values, so when you eval in emacs for example (parse-integer "243") it shows as 2433, with this fix it will print correctly:

243
3

@joaotavora
Copy link
Owner

so when you eval in emacs for example (parse-integer "243")

What method of evaluation are you using? REPL? C-x C-e? I can't reproduce this.

@bo-tato
Copy link
Author

bo-tato commented Apr 25, 2023

ah true, I got it using the eval in overlay code from #567
which is running (sly-eval `(slynk:pprint-eval ,(sly-sexp-at-point)))
that overlay code has I think a few edge cases where it doesn't display things right, but unless I'm missing something this one isn't the fault of my sly-eval-sexp-overlay. It seems C-x C-e doesn't call slynk-pprint-values. Without the patch slynk-pprint-values returns the string "2433", after the patch it returns the string:

243
3

with the newline as I think is intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants