Es netssl #1

jocelyn · 2018-02-26T12:58:44Z

for review

Added example showing encrypt- decrypt using aes gcm 256 based on OpenSSL example.

Added test case gcm decrypt

Merge openssl.ecf and test into openssl.ecf. Splitted the APPLICATION.make feature. Removed a few warnings.

Made BYTE_ARRAY_CONVERTER as hidden (implementation) class.

… low level code wrapping C code. Initial commit gcm encrypt (work in progress).

Added new interfaces to represent the different modes and algorithm supported by OpenSSL and a generic way to encrypt/decrypt.

Added ERROR abstractions to handle OpenSSL errors. Updated low level api to handle errors at the moment using Exceptions. Added test cases to show AES with GCM mode encrypt/decrypt.

SSL_CIPHER_CONTEXT interface.

… into es_openssl_crypto # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

SSL class Added `ssl_get_error` to get the result code of for a preceding call to SSL_connect(), SSL_accept(), SSL_do_handshake(), SSL_read(), SSL_peek(), or SSL_write() on ssl. Added externals features to get the value of different error codes: SSL_ERROR_WANT_READ, SSL_ERROR_NONE, SSL_ERROR_ZERO_RETURN, SSL_ERROR_WANT_WRITE Added external feature `ssl_pending` to return the number of bytes with are available inside SSL for inmediate read. Updated NetSSL library to support non-blocking reads and writes. Added a non blocking client/server example.

jocelyn

Major issue related to visibility of BYTE_ARRAYED_CONVERTER.
Many functions should be renamed to follow Eiffel rules.

and a few cosmetic points.

jocelyn · 2018-02-26T13:10:09Z

Src/unstable/library/network/openssl/openssl.ecf

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="ISO-8859-1"?>
 <system xmlns="http://www.eiffel.com/developers/xml/configuration-1-17-0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.eiffel.com/developers/xml/configuration-1-17-0 http://www.eiffel.com/developers/xml/configuration-1-17-0.xsd" name="openssl" uuid="22EE78DC-1AC1-4EBC-8AA9-9E8D6B8C3989" library_target="openssl">
 	<target name="openssl">
-			<description>Eiffel OpenSSL Wrap library.
+		<description>Eiffel OpenSSL Wrap library.
      Copyright (c) 1984-2006, Eiffel Software and others.


copyright year should be updated

jocelyn · 2018-02-26T13:11:13Z

Src/unstable/library/network/openssl/src/crypto/algorithms/ssl_algorithm.e

+	verify_key_size: BOOLEAN
+			-- has the current algorithm a valid key size?
+		do
+			if key_sizes.has (key_size) then


Result := key_sizes.has (key_size)

jocelyn · 2018-02-26T13:13:09Z

...e/library/network/openssl/src/crypto/interface/implementation/ssl_aead_cipher_context_impl.e

+			Result := ctx.update (a_data)
+		end
+
+   update_into(a_data, a_buf: MANAGED_POINTER): INTEGER


bad indentation, and missing space before (

jocelyn · 2018-02-26T13:15:05Z

...e/library/network/openssl/src/crypto/interface/implementation/ssl_aead_cipher_context_impl.e

+			else
+				updated := True
+				bytes_processed := bytes_processed + a_data_size
+--				if bytes_processed > ctx.mode.MAX_ENCRYPTED_BYTES then


either add a comment related to the commented lines, or remove those lines

jocelyn · 2018-02-26T13:25:08Z

...e/library/network/openssl/src/crypto/interface/implementation/ssl_aead_cipher_context_impl.e

+
+feature -- Access
+
+	ctx: SSL_CIPHER_CONTEXT_EXTERNALS


should ctx be protected (export NONE) and renamed implementation or externals ?

yes, I will export it to {NONE}, but I like the name ctx or context since it's more natural in this domain.

jocelyn · 2018-02-26T14:04:25Z

Src/unstable/library/network/openssl/src/ssl.e

+	 		"return SSL_pending((const SSL *)$a_ssl);"
+	 	end
+
+
 note
 	copyright: "Copyright (c) 1984-2016, Eiffel Software and others"


update copyright year.

jocelyn · 2018-02-26T14:05:03Z

Src/unstable/library/network/openssl/src/ssl_error_factory.e

+
+feature -- Errors
+
+	retrieve_errors: detachable LIST [SSL_ERROR]


bad name for a function

jocelyn · 2018-02-26T14:08:10Z

Src/unstable/library/network/openssl/test/example_gcm.e

+		do
+
+				-- Create and initialise the context
+			l_ctx := {SSL_EVP}.c_evp_cipher_ctx_new


SSL_EVP is in folder "to_remove" ... please also move related tests to a folder "to_remove".
As I guess this is useless to review code that is about to be removed.

jocelyn · 2018-02-26T14:11:05Z

Src/unstable/library/network/openssl/test/test_aes_mode_gcm.e

+			create l_mode.make ("8b23299fde174053f3d652ba", Void)
+			create cipher.make (l_algo, l_mode)
+			l_encryptor := cipher.encryptor
+			l_computed_ct := l_encryptor.update (create {MANAGED_POINTER}.make_from_array ((create {BYTE_ARRAY_CONVERTER}.make_from_hex_string ("28286a321293253c3e0aa2704a278032")).to_natural_8_array))


Note that BYTE_ARRAY_CONVERTER is for now hidden (as implementation).
So user won't be able to use it directly.
then, the interface should have several version of update ... update_with_string, update_with_hexadecimal_string and so on ...

I am not sure if l_computed_ct as a MANAGED_POINTER is really user friendly.
Could we have higher abstraction?
maybe the l_encryptor should keep an attribute with the internal computed result after update ...

I think this is what we have in crypto lib for HMAC_SHA256 and related.

jocelyn · 2018-02-26T14:15:29Z

...able/library/network/socket/netssl/examples/non_blocking/client_server/client/echo_client.rc

@@ -0,0 +1,6 @@
+#include <windows.h>


do not commit generated .rc files

Clean Code. Updated SSL_CIPHER_INTERFACE's to follow Eiffel Style. Refactor rename features to follow Eiffel Style.

…tion Clean code. Remove obsolete cluster: to_remove.

… into es_netssl

Updated OpenSSL dynamic ecf to use the latest dynamic library. Updated OpenSSL readme with information about how to compile it (generate static and dynamic library) and how to install it on Ubuntu (Debian) Linux. Updated Delivery with the latest OpenSSL libraries for Visual Studio C++ win64 and win32

jvelilla and others added 14 commits January 10, 2018 16:20

Initial import EVP GCM mode.

f895ee2

Updated SSL_EVP interface : added encryption features.

8a6f308

Added example showing encrypt- decrypt using aes gcm 256 based on OpenSSL example.

Updated Decrypt example using byte array converter.

4fad1e6

Initial SSL_GCM high level API.

ad3a902

Added test case gcm decrypt

Made BYTE_ARRAY_CONVERTER as hidden (implementation) class.

7e112ac

Merge openssl.ecf and test into openssl.ecf. Splitted the APPLICATION.make feature. Removed a few warnings.

Merge pull request #1 from jocelyn/es_openssl_crypto

85d8231

Made BYTE_ARRAY_CONVERTER as hidden (implementation) class.

Updated OpenSSL crypto cluster, added a new cluster `wrapper' to have…

774e3c2

… low level code wrapping C code. Initial commit gcm encrypt (work in progress).

Update OpenSSL libcrypto interface.

99dd2b8

Updated SSL crypt algorithms.

1e3ce4d

Added new interfaces to represent the different modes and algorithm supported by OpenSSL and a generic way to encrypt/decrypt.

Updated OpenSSL crypto targeting Symmetric encryption (ie AES with GCM).

7ede1e2

Added ERROR abstractions to handle OpenSSL errors. Updated low level api to handle errors at the moment using Exceptions. Added test cases to show AES with GCM mode encrypt/decrypt.

Renamed cluster experimental as to_remove.

6cc35d7

Updated SSL_CIPHER_CONTEXT_EXTERNAL implementation with the

87b3e27

SSL_CIPHER_CONTEXT interface.

jocelyn commented Feb 26, 2018

View reviewed changes

jvelilla added 5 commits March 1, 2018 20:55

Updated copyright.

128b255

Clean Code. Updated SSL_CIPHER_INTERFACE's to follow Eiffel Style. Refactor rename features to follow Eiffel Style.

Updated directory structure to describe symetric and asymetric encryp…

a3dc4c2

…tion Clean code. Remove obsolete cluster: to_remove.

Merge branch 'master' of https://github.com/EiffelSoftware/EiffelStudio…

8c45fde

… into es_netssl

Merge branch 'master' of https://github.com/EiffelSoftware/EiffelStudio…

397c18c

… into es_netssl

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Es netssl #1

Es netssl #1

jocelyn commented Feb 26, 2018

jocelyn left a comment

jocelyn Feb 26, 2018

jvelilla Feb 28, 2018

jocelyn Feb 26, 2018

jvelilla Feb 28, 2018

jocelyn Feb 26, 2018

jvelilla Feb 28, 2018

jocelyn Feb 26, 2018

jvelilla Feb 28, 2018

jocelyn Feb 26, 2018

jvelilla Feb 28, 2018

jocelyn Feb 26, 2018

jocelyn Feb 26, 2018

jocelyn Feb 26, 2018

jocelyn Feb 26, 2018

jocelyn Feb 26, 2018

jocelyn Feb 26, 2018


		feature -- Errors

		retrieve_errors: detachable LIST [SSL_ERROR]

Es netssl #1

Are you sure you want to change the base?

Es netssl #1

Conversation

jocelyn commented Feb 26, 2018

jocelyn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment