Micro karaoke additions #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not include song files; that will be separate commit. Micro Karaoke lets users upload mp4 movie files of themselves singing short bits of a song, and then later download all the video pieces to assemble a music video. Swiftarr controls creation of songs (the playlist), dispensing offers to record parts of songs (effectively reservations for song slots), uploading video files, producing manifests of all the files need to assemble to make a song video, notifying users of completed songs, and content moderation. API changes include: - new structs only used by Micro Karaoke - a new field in the Global Notification struct, - a new App Feature enum case, - new notification type, - new Report types (both Songs and Song Snippets are Reportable content), - new User Role,
Vocal and Karaoke audio, cut up into ~6 second clips, plus lyrics for each clip.
# Conflicts: # Sources/swiftarr/Site/SiteModController.swift
I do not understand why, for a song file with one audio track and no video, has 'songFile.duration > songFile.tracks[0].duration'. How is the duration of the media always about .05 secondslonger than the duration of its only track? Anyway, snippet durations are fixed now.
cohoe
requested changes
Feb 24, 2024
Sources/swiftarr/Resources/Assets/microkaraoke/Code Monkey/0/listen.mp3
Outdated
Show resolved
Hide resolved
# Conflicts: # docs/Swiftarr/API Changelist.md
Will add a new repo with these.
This supports making the microkaraoke assets their own repo and symlinking them into place.
cohoe
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micro Karaoke lets users upload mp4 movie files of themselves singing short bits of a song, and then later download all the video pieces to assemble a music video. Swiftarr controls creation of songs (the playlist), dispensing offers to record parts of songs (effectively reservations for song slots), uploading video files, producing manifests of all the files need to assemble to make a song video, notifying users of completed songs, and content moderation.
API changes include:
This PR includes all of the song data files, which are mostly organized into numbered folders. There's a lot of them. Generally, for every folder there's a "listen.mp3" file which is a 3-10 sec song clip with vocals, a "record.mp3" file which is karaoke backing audio for the same portion of the song, and a "lyrics.txt" file which is the lyric being sung in the "listen" file.