Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal Events #311

Merged
merged 39 commits into from
Oct 2, 2024
Merged

Personal Events #311

merged 39 commits into from
Oct 2, 2024

Conversation

cohoe
Copy link
Member

@cohoe cohoe commented Aug 23, 2024

This adds the construct of Personal Events to Swiftarr. These are calendar objects created and generally viewed only by the creator. The owner can add users who have already favorited them (aka their friends/followers). Just in case, Personal Events are reportable in case friends do bad things.

PersonalEvents was built so that users can have a single pane of glass to view their daily schedule. Bouncing between device calendar and twitarr apps can be abnoxious and doesn't deal with our time zone shenanigans.

PR also allows users to favorite/unfavorite users and view their favorites in the site UI.

Closes #294 and #310

@cohoe cohoe requested a review from challfry August 23, 2024 02:39
@cohoe cohoe marked this pull request as ready for review August 23, 2024 02:39
Copy link
Member

@hendricksond hendricksond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, all I've looked at is the database stuff. Definitely open to discussion if you don't want to make these changes.

@challfry
Copy link
Collaborator

I feel the web UI should really have a way to view a user's personal events, and likely a form to create new ones. Especially since without this, a native app user could create an event, invite users who are web-only, and the web users would have no way of accessing the event.

There was a conversation about this back in the Twitarr 2.0 days, the idea was that the web UI would always be feature-complete (relative to the available API features) from both a user and moderator perspective, while other clients could pick and choose as needed. This isn't quite the case anymore, but that's mostly for technical reasons. Micro Karaoke doesn't display completed videos using the web UI because it does not have them, you can't record MK clips from the web UI because I have no idea how to do that (mostly the real-time audio filtering), and the telephone feature doesn't work because it seems really hard to do on the web.

Anyway, none of that's the case here. Showing the personal events a user is scheduled for is doable and provides value to users.

@cohoe
Copy link
Member Author

cohoe commented Sep 3, 2024

I feel the web UI should really have a way to view a user's personal events, and likely a form to create new ones. Especially since without this, a native app user could create an event, invite users who are web-only, and the web users would have no way of accessing the event.

There was a conversation about this back in the Twitarr 2.0 days, the idea was that the web UI would always be feature-complete (relative to the available API features) from both a user and moderator perspective, while other clients could pick and choose as needed. This isn't quite the case anymore, but that's mostly for technical reasons. Micro Karaoke doesn't display completed videos using the web UI because it does not have them, you can't record MK clips from the web UI because I have no idea how to do that (mostly the real-time audio filtering), and the telephone feature doesn't work because it seems really hard to do on the web.

Anyway, none of that's the case here. Showing the personal events a user is scheduled for is doable and provides value to users.

I agree. My intention is to do a somewhat major overhaul of the "Events" section of the Site UI. In Tricordarr I've made a distinction of "Schedule" == show whats happening, object types Event, PersonalEvent, and optionally Fez. Mostly to disambiguate the coding structures for "Event" and "PersonalEvent" and "Fez". Anywho, I don't want to wrap this refactor into this PR because 1) it's gonna be really big and difficult to separate from the underlying personal event code and 2) I plan to work on it later.

Copy link
Collaborator

@challfry challfry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. There's still no UI for the web client to show users their personal events, but let's get this merged in so it's done.

@cohoe cohoe merged commit 8c5bf00 into jocosocial:master Oct 2, 2024
1 check passed
@cohoe cohoe deleted the personalevents branch October 2, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Personal Events
3 participants