Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused imports and enforce Clippy lints #15

Merged

Conversation

liamaharon
Copy link
Collaborator

Fixes some clippy stuff and adds a CI check to prevent it occurring again.

@liamaharon liamaharon marked this pull request as draft November 7, 2023 06:21
@liamaharon liamaharon changed the title Cleanup unused imports and improve CI Cleanup unused imports and add Clippy lints Nov 7, 2023
@liamaharon liamaharon marked this pull request as ready for review November 7, 2023 06:41
@liamaharon liamaharon changed the title Cleanup unused imports and add Clippy lints Cleanup unused imports and enforce Clippy lints Nov 7, 2023
@@ -1,449 +1,424 @@
#[cfg(test)]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this module is already feature gated in main.rs, so we don't need it again here

proof_size: 1_000_000,
}),
}
use crate::polkadot_relay::runtime_types::frame_system::pallet::Call as PolkadotRelaySystemCall;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad diff. just removes mod tests, because the file already creates a module called tests for this code.

Copy link
Owner

@joepetrowski joepetrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you

@joepetrowski joepetrowski merged commit 218d437 into joepetrowski:master Jan 22, 2024
3 checks passed
@liamaharon liamaharon deleted the liam-unused-imports-and-clippy branch January 23, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants