[dataflowengineoss] take into account frontends that use the -1 index for named arguments
#5000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierpinho
added
bug
…ex for named arguments
xavierpinho
force-pushed
the
xavierp/flow-return-named-arg
branch
from
c9c5178
to
c5becd7
Compare
DavidBakerEffendi
approved these changes
Oct 14, 2024
| case _ => false | ||
| // Some frontends (e.g. python) denote named arguments using `-1` as the argument index. As such | ||
| // `-1` denotes the return value only if there's no argument name. | ||
| case FlowMapping(_, ParameterNode(-1, None)) => true |
There was a problem hiding this comment.
Ah good catch. Yes argumentIndex = -1 is the default value, it is "unset" but in this instance it'll clash with the return value logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-1is used to denote a call's return value. However, some frontends (e.g. python) also use this index for named arguments. When specifyingFlowSemantics, the criteria for deciding if aFlowSemantictaints the return value was not taking this fact into account. This makes sure that-1only denotes the return value if it's not in the context of a named argument specification.