[ruby_ast_gen] Handling for Singleton & Anon Classes #5006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, added handling for range operators and lowered hash arguments in calls to named arguments to be consistent with current ANTLR interpretation of these args.
AndreiDreyer
approved these changes
Oct 17, 2024
max-leuthaeuser
requested changes
Oct 17, 2024
joern-cli/frontends/x2cpg/src/main/scala/io/joern/x2cpg/astgen/AstGenRunner.scala
Outdated
Show resolved
Hide resolved
DavidBakerEffendi
added a commit
that referenced
this pull request
Oct 17, 2024
* Ruby AST Gen downloaded and unpacked * Put AST Gen in front of ANTLR * More entries * Implemented JRuby for standalone capabilities. Edited SBT to help with DownloadHelper's assumptions on ensuring files are available. * Migrated to creating RubyNodeCreator-style nodes directly * Added all AstType entries * Create match entries for all enums * Added empty visit methods for each AST type * More work on basic cases * Completed exhaustive list * Completed visitors for all types * Executing JRuby from Joern's JVM process as dependency * Inserted more missing cases * Applied some control structures * [ruby] Added json visitors for ifStmt, while, begin..end until * Handle initial class/module body creation & summary creation (#5002) * Handle initial class/module body creation & summary creation * Separated tests between versions * [ruby_ast_gen] Handling for Singleton & Anon Classes (#5006) * Improved runner stability and handling class fields * [ruby_ast_gen] Handling for Singleton & Anon Classes Additionally, added handling for range operators and lowered hash arguments in calls to named arguments to be consistent with current ANTLR interpretation of these args. * Roll back AstGenRunner changes * Remove line for diff * Progress push * Finished control structures --------- Co-authored-by: David Baker Effendi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, added handling for range operators and lowered hash arguments in calls to named arguments to be consistent with current ANTLR interpretation of these args.
Also, I noticed the runner may fail, so I added a retry mechanism.