apply changes from code review.

joethei · Dec 7, 2021 · 5b2a4b9 · 5b2a4b9
1 parent 23cc414
commit 5b2a4b9
Showing 1 changed file with 12 additions and 16 deletions.
diff --git a/src/main.ts b/src/main.ts
@@ -27,43 +27,39 @@ export default class TTSPlugin extends Plugin {
 		this.addCommand({
 			id: 'start-tts-playback',
 			name: 'Start playback',
-			checkCallback: (checking: boolean) => {
-				const markdownView = this.app.workspace.getActiveViewOfType(MarkdownView);
-				if (!markdownView) return;
-				if (checking)
-					return !!(markdownView);
-				this.ttsService.play(markdownView);
-
+			editorCallback: (editor, view) => {
+				this.ttsService.play(view);
 			}
 		});
 
 		this.addCommand({
 			id: 'cancel-tts-playback',
 			name: 'Stop playback',
 			checkCallback: (checking: boolean) => {
-				if (checking)
-					return this.ttsService.isSpeaking();
-				this.ttsService.stop();
+				if (!checking)
+					this.ttsService.stop();
+				return this.ttsService.isSpeaking();
+
 			}
 		});
 
 		this.addCommand({
 			id: 'pause-tts-playback',
 			name: 'pause playback',
 			checkCallback: (checking: boolean) => {
-				if (checking)
-					return this.ttsService.isSpeaking();
-				this.ttsService.pause();
+				if (!checking)
+					this.ttsService.pause();
+				return this.ttsService.isSpeaking();
 			}
 		});
 
 		this.addCommand({
 			id: 'resume-tts-playback',
 			name: 'Resume playback',
 			checkCallback: (checking: boolean) => {
-				if (checking)
-					return this.ttsService.isPaused();
-				this.ttsService.resume();
+				if (!checking)
+					this.ttsService.resume();
+				return this.ttsService.isPaused();
 			}
 		});