Truncation of comment body and changes to matching of comic numbers #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1, the bot should only handle up to a certain amount of characters to prevent any kind of overload.
Also, since as of today the number of xkcd comics is less than 2500, the regex shouldn't match any ridiculously large numbers as that could cause issues for no reason.
So in order to address these two issues, I truncated the body's length to 5000 and I changed the regex so it will only match numbers up to 6 digits long. Which should be more than enough and it's also a fairly small number for Python to handle.