Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiate work on PutObjectTagging ref PR#71 and issue #72 #75

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

johannesboyne
Copy link
Owner

@johannesboyne johannesboyne commented Dec 29, 2022

This fixes issue #72 and builds on PR #71

If the general implementation would work like this as expected, we could extend the test cases a bit and then merge this PR.

@johannesboyne johannesboyne added WIP Work in progress bugfix labels Dec 29, 2022
@johannesboyne johannesboyne marked this pull request as draft December 29, 2022 13:06
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.1% 8.1% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (c55a48f) 65.94% compared to head (940f235) 65.74%.

Files Patch % Lines
gofakes3.go 56.25% 7 Missing and 7 partials ⚠️
routing.go 69.23% 4 Missing ⚠️
backend/s3afero/single.go 33.33% 2 Missing ⚠️
backend/s3afero/multi.go 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   65.94%   65.74%   -0.21%     
==========================================
  Files          28       28              
  Lines        2693     2744      +51     
==========================================
+ Hits         1776     1804      +28     
- Misses        651      666      +15     
- Partials      266      274       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannesboyne
Copy link
Owner Author

@elgohr see this implementation as a first step, your test case is running with this but might be good to check out your real-world case against this to see, whether it actually works and behaves as expected.

@johannesboyne johannesboyne marked this pull request as ready for review January 8, 2023 15:15
@johannesboyne johannesboyne removed the WIP Work in progress label Jan 8, 2023
@johannesboyne johannesboyne force-pushed the feature-PutObjectTagging branch from 5b1d549 to 439bdb7 Compare February 17, 2024 10:05
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants