-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initiate work on PutObjectTagging ref PR#71 and issue #72 #75
base: master
Are you sure you want to change the base?
Conversation
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 65.94% 65.74% -0.21%
==========================================
Files 28 28
Lines 2693 2744 +51
==========================================
+ Hits 1776 1804 +28
- Misses 651 666 +15
- Partials 266 274 +8 ☔ View full report in Codecov by Sentry. |
@elgohr see this implementation as a first step, your test case is running with this but might be good to check out your real-world case against this to see, whether it actually works and behaves as expected. |
5b1d549
to
439bdb7
Compare
Quality Gate failedFailed conditions |
This fixes issue #72 and builds on PR #71
If the general implementation would work like this as expected, we could extend the test cases a bit and then merge this PR.