Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve pagespeed by decreasing resize debounce timer #33

Closed

Conversation

felixranesberger
Copy link
Contributor

Google Pagespeed tells me, that my images are not the correct size, but only in desktop mode.
I think Google Pagespeed resizes the window and doesn't wait long enaugh for the debounce effect to "settle" and update the size attribute.

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for unlazy ready!

Name Link
🔨 Latest commit 5792cd3
🔍 Latest deploy log https://app.netlify.com/sites/unlazy/deploys/65316af23feaf50008028b87
😎 Deploy Preview https://deploy-preview-33--unlazy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johannschopplich
Copy link
Owner

Hi there!
Thanks for the pull request. While a smaller debounce delay might be beneficial, I suspect it won't fix the Google error.

Could you patch your local unlazy dependency with the decreased delay and share the Pagespeed results, please? I'd like to have some feedback beforehand.

@johannschopplich
Copy link
Owner

@felixranesberger Did you use the <picture> tag? If so, this might be related with #43 and is already resolved. I'm closing this for now. Feel free to open a new issue anytime. 🙂

@felixranesberger
Copy link
Contributor Author

Hi Johann, I didn't use the <picture> tag, but I think the issue was on my side.
I simply forgot to close the pull request 😅

Also congrats on your new job at Finanzfluss.
Huge fan of their content!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants